Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2555413002: Revert commit# 415577 "Add grid/flex layout support for <fieldset>" (Closed)

Created:
4 years ago by Gleb Lanbin
Modified:
4 years ago
Reviewers:
ikilpatrick
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert commit# 415577 "Add grid/flex layout support for <fieldset>" This patch partially reverts crrev.com/415577. Reason for revert: Broke real world websites. BUG=670837 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2549973003 Cr-Commit-Position: refs/heads/master@{#436992}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -477 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +13 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html View 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex-expected.html View 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html View 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid-expected.html View 1 chunk +0 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 4 chunks +13 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.h View 2 chunks +10 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 5 chunks +13 lines, -153 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.h View 4 chunks +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 7 chunks +6 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555413002/20001
4 years ago (2016-12-08 00:25:45 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-08 00:25:46 UTC) #6
ikilpatrick
lgtm
4 years ago (2016-12-08 00:31:30 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-08 00:33:02 UTC) #10

Powered by Google App Engine
This is Rietveld 408576698