Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837
Committed: https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603
Cr-Commit-Position: refs/heads/master@{#436992}

[Gleb Lanbin, 2016-12-03 17:20:03]

Description was changed from

==========
revert

BUG=
==========

to

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=661230
==========

[Gleb Lanbin, 2016-12-03 17:21:20]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org, eae@chromium.org

[Gleb Lanbin, 2016-12-03 17:27:34]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 17:27:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-12-03 18:44:28]

Description was changed from

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=661230
==========

to

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=661230,670837
==========

[cbiesinger, 2016-12-03 18:44:41]

lgtm. I added the other bug to the BUG= line too.

[commit-bot: I haz the power, 2016-12-03 19:01:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 19:01:48]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Gleb Lanbin, 2016-12-03 20:59:11]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-03 20:59:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2016-12-03 22:12:52]

On 2016/12/03 18:44:41, cbiesinger wrote:
> lgtm. I added the other bug to the BUG= line too.

Christian, thank you for the quick review.
Could you take a look at http://crrev.com/2550963002? That patch will fix the
problem found on real websites. I would like to proceed with
http://crrev.com/2550963002 instead of this one.

[commit-bot: I haz the power, 2016-12-03 23:01:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-03 23:01:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Gleb Lanbin, 2016-12-06 19:34:16]

Description was changed from

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=661230,670837
==========

to

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837
==========

[Gleb Lanbin, 2016-12-06 19:34:16]

glebl@chromium.org changed reviewers:
- eae@chromium.org

[Gleb Lanbin, 2016-12-06 22:41:44]

Patchset #1 (id:1) has been deleted

[Gleb Lanbin, 2016-12-06 22:41:51]

Patchset #1 (id:20001) has been deleted

[Gleb Lanbin, 2016-12-06 22:41:58]

Patchset #1 (id:40001) has been deleted

[Gleb Lanbin, 2016-12-07 08:42:40]

Patchset #1 (id:60001) has been deleted

[Gleb Lanbin, 2016-12-07 08:42:47]

Patchset #1 (id:80001) has been deleted

[Gleb Lanbin, 2016-12-07 13:50:45]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 13:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gleb Lanbin, 2016-12-07 13:53:53]

On 2016/12/03 22:12:52, Gleb Lanbin wrote:
> On 2016/12/03 18:44:41, cbiesinger wrote:
> > lgtm. I added the other bug to the BUG= line too.
> 
> Christian, thank you for the quick review.
> Could you take a look at http://crrev.com/2550963002 That patch will fix the
> problem found on real websites. I would like to proceed with
> http://crrev.com/2550963002 instead of this one.

please disregard the last comment. I'm submitting this patch

[Gleb Lanbin, 2016-12-07 15:29:39]

The CQ bit was unchecked by glebl@chromium.org

[Gleb Lanbin, 2016-12-07 15:29:43]

The CQ bit was checked by glebl@chromium.org

[Gleb Lanbin, 2016-12-07 15:29:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
cbiesinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2549973003/#ps120001
(title: "updated TestExpectations, verified that there are no changes in
images")

[commit-bot: I haz the power, 2016-12-07 15:29:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cbiesinger, 2016-12-07 16:13:46]

https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (right):

https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:1951: crbug.com/670837
fast/css/fieldset-display-row.html [ NeedsRebaseline ]
prefer the support in webkit-patch over using the rebaseline bot.
https://groups.google.com/a/chromium.org/d/msg/blink-dev/A4HwldX-wFo/OlWBdQE8...

[Gleb Lanbin, 2016-12-07 16:19:22]

On 2016/12/07 16:13:46, cbiesinger wrote:
>
https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
> File third_party/WebKit/LayoutTests/TestExpectations (right):
> 
>
https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
> third_party/WebKit/LayoutTests/TestExpectations:1951: crbug.com/670837
> fast/css/fieldset-display-row.html [ NeedsRebaseline ]
> prefer the support in webkit-patch over using the rebaseline bot.
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/A4HwldX-wFo/OlWBdQE8...

I had to use TestsExpectations because of http://crrev.com/436921 that was
submitted a bit earlier.

[Gleb Lanbin, 2016-12-07 16:54:57]

On 2016/12/07 16:19:22, Gleb Lanbin wrote:
> On 2016/12/07 16:13:46, cbiesinger wrote:
> >
>
https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
> > File third_party/WebKit/LayoutTests/TestExpectations (right):
> > 
> >
>
https://codereview.chromium.org/2549973003/diff/120001/third_party/WebKit/Lay...
> > third_party/WebKit/LayoutTests/TestExpectations:1951: crbug.com/670837
> > fast/css/fieldset-display-row.html [ NeedsRebaseline ]
> > prefer the support in webkit-patch over using the rebaseline bot.
> >
>
https://groups.google.com/a/chromium.org/d/msg/blink-dev/A4HwldX-wFo/OlWBdQE8...
> 
> I had to use TestsExpectations because of http://crrev.com/436921 that was
> submitted a bit earlier.

also the new way doesn't work for me. I'm getting
$ third_party/WebKit/Tools/Scripts/webkit-patch rebaseline-cl
...
File
"/usr/local/google/home/glebl/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/factory.py",
line 76, in _check_configuration_and_target
    raise ValueError('Configuration does not match the GN build args.')
ValueError: Configuration does not match the GN build args.

so I decided to use TestsExpectations instead. I'm planning to rebaseline
affected tests manually if needed after this patch is submitted.

[cbiesinger, 2016-12-07 17:01:41]

Huh interesting. +qyearsley FYI (see above comment).

Meanwhile, lgtm to commit this, but it would be good to fix it longer-term.

[commit-bot: I haz the power, 2016-12-07 17:33:54]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481124583724690,
"parent_rev": "22a3e4a772165a624cabdca8638744655a086f74", "commit_rev":
"ac2bd1414cdbe1b4dfd1b2b0af414391ad5fdd7a"}

[commit-bot: I haz the power, 2016-12-07 17:34:27]

Description was changed from

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837
==========

to

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837
==========

[commit-bot: I haz the power, 2016-12-07 17:34:28]

Committed patchset #2 (id:120001)

[commit-bot: I haz the power, 2016-12-07 17:36:22]

Description was changed from

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837
==========

to

==========
Revert commit# 415577 "Add grid/flex layout support for <fieldset>"

This patch partially reverts crrev.com/415577.
Reason for revert: Broke real world websites.

BUG=670837

Committed: https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603
Cr-Commit-Position: refs/heads/master@{#436992}
==========

[commit-bot: I haz the power, 2016-12-07 17:36:23]

Patchset 2 (id:??) landed as
https://crrev.com/9a34c8753d57bdcf88b27e6df780877880820603
Cr-Commit-Position: refs/heads/master@{#436992}