In case of an error in AutofillCounter's queries, do not crash.

In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is marked as being complete by being removed from the WebDataRequestManager's pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside OnWebDataServiceRequestDone. By that time, it has been removed from the pending_requests_ map and is no longer allowed to be canceled. Therefore, make sure that AutofillCounter marks it as being complete so that it doesn't try to cancel it.

BUG=672823
Committed: https://crrev.com/a8bf8fe81c52ff662d381a06a79d8ba68ae37ba2
Cr-Commit-Position: refs/heads/master@{#437885}

[Avi (use Gerrit), 2016-12-10 01:20:23]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 01:20:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 01:55:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 01:55:27]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Avi (use Gerrit), 2016-12-10 20:32:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 20:33:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 21:10:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 21:10:53]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-12-10 21:12:53]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-10 21:12:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Avi (use Gerrit), 2016-12-10 21:14:04]

avi@chromium.org changed reviewers:
+ bauerb@chromium.org

[Avi (use Gerrit), 2016-12-10 21:14:04]

Bernhard: review
Mathieu: FYI

[commit-bot: I haz the power, 2016-12-10 22:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 22:05:30]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2016-12-12 14:56:26]

Code-wise LGTM, but could you explain in the CL description a) what this change
does, and b) why this fixes the crash? Thanks!

https://codereview.chromium.org/2555373007/diff/40001/components/browsing_dat...
File components/browsing_data/core/counters/autofill_counter.cc (right):

https://codereview.chromium.org/2555373007/diff/40001/components/browsing_dat...
components/browsing_data/core/counters/autofill_counter.cc:94: }
Maybe add an else { NOTREACHED(); } just for completeness?

[Avi (use Gerrit), 2016-12-12 15:13:27]

Description was changed from

==========
In case of an error in AutofillCounter's queries, do not crash.

BUG=672823
==========

to

==========
In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is
marked as being complete by being removed from the WebDataRequestManager's
pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside
OnWebDataServiceRequestDone. By that time, it has been removed from the
pending_requests_ map and is no longer allowed to be canceled. Therefore, make
sure that AutofillCounter marks it as being complete so that it doesn't try to
cancel it.

BUG=672823
==========

[Avi (use Gerrit), 2016-12-12 15:16:44]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2016-12-12 15:16:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2555373007/#ps60001
(title: "rev")

[Avi (use Gerrit), 2016-12-12 15:16:48]

https://codereview.chromium.org/2555373007/diff/40001/components/browsing_dat...
File components/browsing_data/core/counters/autofill_counter.cc (right):

https://codereview.chromium.org/2555373007/diff/40001/components/browsing_dat...
components/browsing_data/core/counters/autofill_counter.cc:94: }
On 2016/12/12 14:56:26, Bernhard Bauer wrote:
> Maybe add an else { NOTREACHED(); } just for completeness?

Done.

[commit-bot: I haz the power, 2016-12-12 15:17:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:29:23]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481555804546280,
"parent_rev": "4e887c9dc1192de2673da07d66247c11f4846f26", "commit_rev":
"c9683ceb35331eaadea270c82a57dfebaa7a831b"}

[commit-bot: I haz the power, 2016-12-12 16:29:51]

Description was changed from

==========
In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is
marked as being complete by being removed from the WebDataRequestManager's
pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside
OnWebDataServiceRequestDone. By that time, it has been removed from the
pending_requests_ map and is no longer allowed to be canceled. Therefore, make
sure that AutofillCounter marks it as being complete so that it doesn't try to
cancel it.

BUG=672823
==========

to

==========
In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is
marked as being complete by being removed from the WebDataRequestManager's
pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside
OnWebDataServiceRequestDone. By that time, it has been removed from the
pending_requests_ map and is no longer allowed to be canceled. Therefore, make
sure that AutofillCounter marks it as being complete so that it doesn't try to
cancel it.

BUG=672823

Review-Url: https://codereview.chromium.org/2555373007
==========

[commit-bot: I haz the power, 2016-12-12 16:29:51]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-12 16:34:25]

Description was changed from

==========
In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is
marked as being complete by being removed from the WebDataRequestManager's
pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside
OnWebDataServiceRequestDone. By that time, it has been removed from the
pending_requests_ map and is no longer allowed to be canceled. Therefore, make
sure that AutofillCounter marks it as being complete so that it doesn't try to
cancel it.

BUG=672823

Review-Url: https://codereview.chromium.org/2555373007
==========

to

==========
In case of an error in AutofillCounter's queries, do not crash.

Before OnWebDataServiceRequestDone is called for a request, the request is
marked as being complete by being removed from the WebDataRequestManager's
pending_requests_ map.

When a query from AutofillCounter fails, it is handled inside
OnWebDataServiceRequestDone. By that time, it has been removed from the
pending_requests_ map and is no longer allowed to be canceled. Therefore, make
sure that AutofillCounter marks it as being complete so that it doesn't try to
cancel it.

BUG=672823

Committed: https://crrev.com/a8bf8fe81c52ff662d381a06a79d8ba68ae37ba2
Cr-Commit-Position: refs/heads/master@{#437885}
==========

[commit-bot: I haz the power, 2016-12-12 16:34:26]

Patchset 4 (id:??) landed as
https://crrev.com/a8bf8fe81c52ff662d381a06a79d8ba68ae37ba2
Cr-Commit-Position: refs/heads/master@{#437885}