Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(913)

Issue 2555373006: MD Settings: cr-policy-pref-indicator: Eliminate controllingUser (Closed)

Created:
4 years ago by stevenjb
Modified:
4 years ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: cr-policy-pref-indicator: Eliminate controllingUser This property is unused and unnecessary. BUG=648498 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8db79167a77b48b6eb30d2631a1e06fe83cc25e0 Cr-Commit-Position: refs/heads/master@{#437587}

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -16 lines) Patch
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js View 1 2 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
4 years ago (2016-12-09 02:23:01 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2555373006/diff/1/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js File ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js (right): https://codereview.chromium.org/2555373006/diff/1/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js#newcode1 ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js:1: revert blank line
4 years ago (2016-12-09 03:23:10 UTC) #4
stevenjb
https://codereview.chromium.org/2555373006/diff/1/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js File ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js (right): https://codereview.chromium.org/2555373006/diff/1/ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js#newcode1 ui/webui/resources/cr_elements/policy/cr_policy_pref_indicator.js:1: On 2016/12/09 03:23:10, michaelpg wrote: > revert blank line ...
4 years ago (2016-12-09 16:51:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555373006/20001
4 years ago (2016-12-09 16:52:15 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 18:13:45 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:14 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8db79167a77b48b6eb30d2631a1e06fe83cc25e0
Cr-Commit-Position: refs/heads/master@{#437587}

Powered by Google App Engine
This is Rietveld 408576698