Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2555253002: Split CFWL_Widget::GetWidgetRect into two parts (Closed)

Created:
4 years ago by dsinclair
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Split CFWL_Widget::GetWidgetRect into two parts This CL splits the inflation logic out of GetWidgetRect to allow subclasses to call that directly instead of the CFWL_Widget::GetWidgetRect method. Committed: https://pdfium.googlesource.com/pdfium/+/67c6ca3cd86b6a31c888264bb8067c6c4324e56c

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M xfa/fwl/core/cfwl_checkbox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_combobox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_datetimepicker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_edit.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_listbox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_monthcalendar.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_picturebox.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fwl/core/cfwl_pushbutton.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_scrollbar.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M xfa/fwl/core/cfwl_spinbutton.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fwl/core/cfwl_widget.h View 1 chunk +1 line, -0 lines 0 comments Download
M xfa/fwl/core/cfwl_widget.cpp View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
dsinclair
PTAL.
4 years ago (2016-12-07 18:45:22 UTC) #2
Tom Sepez
lgtm
4 years ago (2016-12-07 18:54:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555253002/20001
4 years ago (2016-12-08 02:13:22 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-08 02:24:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/67c6ca3cd86b6a31c888264bb8067c6c4324...

Powered by Google App Engine
This is Rietveld 408576698