Cleanup return values in CFWL_ComboBox

Cleanup return values in CFWL_ComboBox

This CL changes methods in CFWL_ComboBox to return values instead of taking
out params.

Committed: https://pdfium.googlesource.com/pdfium/+/a2cbc570a035186529be151af0b3d44cf4106eee

[dsinclair, 2016-12-07 16:42:57]

The CQ bit was checked by dsinclair@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 16:43:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dsinclair, 2016-12-07 16:43:34]

dsinclair@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[dsinclair, 2016-12-07 16:43:35]

PTAL.

[commit-bot: I haz the power, 2016-12-07 16:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:58:55]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-12-07 17:46:14]

yay!

https://codereview.chromium.org/2555103005/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
File xfa/fxfa/app/xfa_ffchoicelist.cpp (right):

https://codereview.chromium.org/2555103005/diff/1/xfa/fxfa/app/xfa_ffchoiceli...
xfa/fxfa/app/xfa_ffchoicelist.cpp:321: CFX_WideString wsSel =
pFWLcombobox->GetTextByIndex(iCursel);
nit: local not needed?

[Tom Sepez, 2016-12-07 17:46:20]

lgtm

[dsinclair, 2016-12-08 01:59:01]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-12-08 01:59:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2555103005/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-12-08 01:59:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 02:10:19]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481162341258710,
"parent_rev": "442997cbb3a9e970946dd294acd1498e9fa9bfc7", "commit_rev":
"a2cbc570a035186529be151af0b3d44cf4106eee"}

[commit-bot: I haz the power, 2016-12-08 02:10:21]

Description was changed from

==========
Cleanup return values in CFWL_ComboBox

This CL changes methods in CFWL_ComboBox to return values instead of taking
out params.
==========

to

==========
Cleanup return values in CFWL_ComboBox

This CL changes methods in CFWL_ComboBox to return values instead of taking
out params.

Committed:
https://pdfium.googlesource.com/pdfium/+/a2cbc570a035186529be151af0b3d44cf410...
==========

[commit-bot: I haz the power, 2016-12-08 02:10:22]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/a2cbc570a035186529be151af0b3d44cf410...