Improving the appearance of overlay scrollbars

Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/632ada879bd7a155f64f9ee9b28634aac5810e92
Cr-Commit-Position: refs/heads/master@{#438542}

[Evan Stade, 2016-12-07 21:56:43]

estade@chromium.org changed reviewers:
+ sadrul@chromium.org

[Evan Stade, 2016-12-07 21:56:47]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 21:57:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:16:34]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sadrul, 2016-12-09 17:12:27]

Sorry, missed this.

The try failures look relevant. But looks easy to fix. lgtm

My suggestion would be to land the change to switch to overlay scrollbars in a
separate CL, so it's easy to revert if we want to without reverting the
cleanups.

[Evan Stade, 2016-12-09 17:56:38]

Description was changed from

==========
Use Overlay scrollbars throughout ChromeOS browser UI.

Much of this patch is dedicated to improving the appearance of overlay
scrollbars with scroll views that have headers (task manager). Much of
it is refactoring to improve readability. Only a few lines are
necessary for flipping the default bars on CrOS.

BUG=672199
==========

to

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
==========

[Evan Stade, 2016-12-09 17:57:00]

tests fixed. I will take your advice and punt flipping the switch to a follow-up
CL.

[Evan Stade, 2016-12-09 17:57:03]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-09 17:57:03]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213004/#ps20001
(title: "don't flip switch")

[commit-bot: I haz the power, 2016-12-09 17:57:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 18:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 18:45:06]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Evan Stade, 2016-12-09 19:09:34]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[Evan Stade, 2016-12-09 19:10:18]

Description was changed from

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
==========

to

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org
==========

[Evan Stade, 2016-12-09 19:10:19]

estade@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-12-09 19:10:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-12-09 19:10:40]

TBR Devlin for trivial change in
chrome/browser/ui/views/toolbar/extension_toolbar_menu_view.cc

[Evan Stade, 2016-12-09 19:10:44]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-12-09 19:10:47]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-09 19:10:47]

The patchset sent to the CQ was uploaded after l-g-t-m from sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213004/#ps40001
(title: "avoid dcheck")

[commit-bot: I haz the power, 2016-12-09 19:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-12-09 19:22:06]

extensions lgtm

[commit-bot: I haz the power, 2016-12-09 20:06:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 20:06:16]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Evan Stade, 2016-12-12 15:35:05]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-12 15:35:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213004/#ps60001
(title: "fix test")

[commit-bot: I haz the power, 2016-12-12 15:35:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 16:14:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 16:14:22]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2016-12-12 16:56:49]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 16:57:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 18:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 18:23:29]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2016-12-13 00:51:52]

https://codereview.chromium.org/2555213004/diff/80001/ui/views/controls/scrol...
File ui/views/controls/scroll_view.cc (right):

https://codereview.chromium.org/2555213004/diff/80001/ui/views/controls/scrol...
ui/views/controls/scroll_view.cc:310: if (horiz_sb_->OverlapsContent() !=
vert_sb_->OverlapsContent())
Sadrul, do you mind this change that I had to make to satisfy Mac? I don't think
there's an easy way around it. See [1] which triggers layout after only one of
the bars (vertical or horizontal) has been updated to a different style.

[1]
https://cs.chromium.org/chromium/src/ui/views/controls/scrollbar/cocoa_scroll...

[Evan Stade, 2016-12-14 16:53:59]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-12-14 16:53:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2555213004/#ps80001
(title: "attempt to fix mac")

[commit-bot: I haz the power, 2016-12-14 16:54:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 18:34:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481734439329530,
"parent_rev": "102b4564423ae52dd0f9a132425dee8014a17946", "commit_rev":
"b6875d9c3c3c7c5465719e27df4f81f12280cbd5"}

[commit-bot: I haz the power, 2016-12-14 18:34:59]

Description was changed from

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org
==========

to

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2555213004
==========

[commit-bot: I haz the power, 2016-12-14 18:35:00]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-14 18:37:40]

Description was changed from

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2555213004
==========

to

==========
Improving the appearance of overlay scrollbars
with scroll views that have headers (like the task manager).
Also a bit of refactor to improve readability.

This has no real effect until we turn on overlay bars in more places.

BUG=672199
TBR=rdevlin.cronin@chromium.org

Committed: https://crrev.com/632ada879bd7a155f64f9ee9b28634aac5810e92
Cr-Commit-Position: refs/heads/master@{#438542}
==========

[commit-bot: I haz the power, 2016-12-14 18:37:41]

Patchset 5 (id:??) landed as
https://crrev.com/632ada879bd7a155f64f9ee9b28634aac5810e92
Cr-Commit-Position: refs/heads/master@{#438542}