Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 25552003: Enable TouchEvent suppression on scroll for all platforms (Closed)

Created:
7 years, 2 months ago by jdduke (slow)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Yufeng Shen (Slow to review), Rick Byers
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Enable TouchEvent suppression on scroll for all platforms Remove the flag for suppressing TouchEvent forwarding to the renderer while scrolling, enabling this feature for all platforms. Also remove the Android-specific implementation of TouchCancel on scroll, instead using the cross-platform implementation now found in TouchEventQueue. BUG=240735 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227090

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : WIP... requires crrev.com/23856016 #

Patch Set 4 : Rebase #

Patch Set 5 : Move unit test #

Patch Set 6 : Test cleanup #

Messages

Total messages: 6 (0 generated)
jdduke (slow)
PTAL for owners. aelias@: content/browser/renderer_host/input jam@: content/public/common tedchoc@: content/public/android
7 years, 2 months ago (2013-10-03 18:29:18 UTC) #1
jam
On 2013/10/03 18:29:18, jdduke wrote: > PTAL for owners. > > aelias@: content/browser/renderer_host/input > jam@: ...
7 years, 2 months ago (2013-10-03 21:27:41 UTC) #2
Ted C
On 2013/10/03 21:27:41, jam wrote: > On 2013/10/03 18:29:18, jdduke wrote: > > PTAL for ...
7 years, 2 months ago (2013-10-03 21:30:09 UTC) #3
aelias_OOO_until_Jul13
lgtm
7 years, 2 months ago (2013-10-04 02:58:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jdduke@chromium.org/25552003/27001
7 years, 2 months ago (2013-10-04 15:15:02 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-04 21:40:00 UTC) #6
Message was sent while issue was closed.
Change committed as 227090

Powered by Google App Engine
This is Rietveld 408576698