Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2555173003: [Do not submit] D3DKMTWaitForVerticalBlankEvent VSync prototype (Closed)

Created:
4 years ago by stanisc
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, cc-bugs_chromium.org, scheduler-bugs_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Do not submit] D3DKMTWaitForVerticalBlankEvent VSync prototype BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Patch Set 1 #

Patch Set 2 : Second iteration (currently not working) #

Patch Set 3 : Third iteration #

Patch Set 4 : Switched to GpuVSyncProvider #

Patch Set 5 : Added command line switch and experiment support #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -19 lines) Patch
M cc/scheduler/begin_frame_source.h View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/compositor/browser_compositor_output_surface.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 2 3 4 3 chunks +8 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 7 chunks +41 lines, -14 lines 0 comments Download
A content/browser/compositor/gpu_vsync_begin_frame_source.h View 1 2 3 4 1 chunk +57 lines, -0 lines 0 comments Download
A content/browser/compositor/gpu_vsync_begin_frame_source.cc View 1 2 3 4 1 chunk +114 lines, -0 lines 1 comment Download
M gpu/ipc/client/command_buffer_proxy_impl.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/ipc/client/command_buffer_proxy_impl.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M gpu/ipc/common/gpu_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.h View 1 2 3 4 5 chunks +27 lines, -0 lines 0 comments Download
M gpu/ipc/service/gpu_command_buffer_stub.cc View 1 2 3 4 9 chunks +63 lines, -1 line 0 comments Download
M ui/gl/gl_switches.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_switches.cc View 1 2 3 4 2 chunks +4 lines, -1 line 1 comment Download
M ui/gl/vsync_provider_win.h View 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (7 generated)
stanisc
3 years, 11 months ago (2017-01-12 00:52:50 UTC) #4 
https://codereview.chromium.org/2555173003/diff/100001/content/browser/compos...
File content/browser/compositor/gpu_vsync_begin_frame_source.cc (right):

https://codereview.chromium.org/2555173003/diff/100001/content/browser/compos...
content/browser/compositor/gpu_vsync_begin_frame_source.cc:100: if (delta <
args.interval / 2.0) {
TODO: this needs logic similar to DelayBasedBeginFrameSource that would prevent
repeated OnBeginFrame signal. May be compare frame iteration and source.

https://codereview.chromium.org/2555173003/diff/100001/ui/gl/gl_switches.cc
File ui/gl/gl_switches.cc (right):

https://codereview.chromium.org/2555173003/diff/100001/ui/gl/gl_switches.cc#n...
ui/gl/gl_switches.cc:133: kUseD3DVSync};
TODO: revert formatting

Powered by Google App Engine
This is Rietveld 408576698