Part 3.8: Is policy list subsumed under subsuming policy?

Part 3.8: Is policy list subsumed under subsuming policy?

This CL (finally) considers list wildcards. For example:
A = *
B = ftp: http: https: ws: wss:

A subsumes B.

However,
if B is "ftp: http: https: ws: wss: 'unsafe-inline'", then A does not
subsume B because `unsafe-inline` is not allowed by A.

BUG=647588
Committed: https://crrev.com/0ff1c62147403c78af7be4edaec99a544bf15987
Cr-Commit-Position: refs/heads/master@{#437298}

[amalika, 2016-12-07 13:14:08]

amalika@google.com changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[amalika, 2016-12-07 13:14:08]

Adding support for wildcards (`*`) in lists.

[amalika, 2016-12-07 13:20:53]

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (left):

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:604: //
TODO(amalika): Handle here special keywords.
Time to remove this :)

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:1242:
{"http://another.test", {"*", "'self'"}, true},
I realized that 'self' is "http://another.test" i.e. there is no path so that
"http://another.test/" does not subsume "http://another.test". This is probably
not intended for `self`?

[Mike West, 2016-12-07 15:16:22]

LGTM % comments.

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (left):

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:604: //
TODO(amalika): Handle here special keywords.
On 2016/12/07 at 13:20:53, amalika wrote:
> Time to remove this :)

Yay \o/

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp (right):

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirective.cpp:685:
getSources(other[0]->m_policy->getSelfSource());
Can you add a note explaining why you're using `other[0]`'s policy's self to
resolve the required policy's self?

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp
(right):

https://codereview.chromium.org/2555153002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/SourceListDirectiveTest.cpp:1242:
{"http://another.test", {"*", "'self'"}, true},
On 2016/12/07 at 13:20:53, amalika wrote:
> I realized that 'self' is "http://another.test" i.e. there is no path so that
"http://another.test/" does not subsume "http://another.test". This is probably
not intended for `self`?

As discussed, please add a test showing the behavior difference between
`http://another.test` and `http://another.test/`, and add a TODO noting that it
probably shouldn't be different. :)

[amalika, 2016-12-08 14:20:50]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 14:21:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 15:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 15:22:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[amalika, 2016-12-08 15:54:26]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 15:54:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 16:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 16:32:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[amalika, 2016-12-08 17:23:53]

Patchset #3 (id:40001) has been deleted

[amalika, 2016-12-08 17:24:01]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 17:24:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:50:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:50:45]

Dry run: This issue passed the CQ dry run.

[amalika, 2016-12-08 18:52:25]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-08 18:52:26]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2555153002/#ps60001
(title: "Fixing c++ empty vector initialization")

[commit-bot: I haz the power, 2016-12-08 18:53:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 18:58:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481223145581210,
"parent_rev": "4c53ba5af9554c2fe0970e7ecf31b124f331f8da", "commit_rev":
"784771af9f8ff6571d3a3efea021edc522537089"}

[commit-bot: I haz the power, 2016-12-08 18:59:06]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-12-08 19:03:31]

Description was changed from

==========
Part 3.8: Is policy list subsumed under subsuming policy?

This CL (finally) considers list wildcards. For example:
A = *
B = ftp: http: https: ws: wss:

A subsumes B.

However,
if B is "ftp: http: https: ws: wss: 'unsafe-inline'", then A does not
subsume B because `unsafe-inline` is not allowed by A.

BUG=647688
==========

to

==========
Part 3.8: Is policy list subsumed under subsuming policy?

This CL (finally) considers list wildcards. For example:
A = *
B = ftp: http: https: ws: wss:

A subsumes B.

However,
if B is "ftp: http: https: ws: wss: 'unsafe-inline'", then A does not
subsume B because `unsafe-inline` is not allowed by A.

BUG=647688

Committed: https://crrev.com/0ff1c62147403c78af7be4edaec99a544bf15987
Cr-Commit-Position: refs/heads/master@{#437298}
==========

[commit-bot: I haz the power, 2016-12-08 19:03:31]

Patchset 3 (id:??) landed as
https://crrev.com/0ff1c62147403c78af7be4edaec99a544bf15987
Cr-Commit-Position: refs/heads/master@{#437298}

[amalika, 2016-12-09 11:45:10]

Description was changed from

==========
Part 3.8: Is policy list subsumed under subsuming policy?

This CL (finally) considers list wildcards. For example:
A = *
B = ftp: http: https: ws: wss:

A subsumes B.

However,
if B is "ftp: http: https: ws: wss: 'unsafe-inline'", then A does not
subsume B because `unsafe-inline` is not allowed by A.

BUG=647688

Committed: https://crrev.com/0ff1c62147403c78af7be4edaec99a544bf15987
Cr-Commit-Position: refs/heads/master@{#437298}
==========

to

==========
Part 3.8: Is policy list subsumed under subsuming policy?

This CL (finally) considers list wildcards. For example:
A = *
B = ftp: http: https: ws: wss:

A subsumes B.

However,
if B is "ftp: http: https: ws: wss: 'unsafe-inline'", then A does not
subsume B because `unsafe-inline` is not allowed by A.

BUG=647588

Committed: https://crrev.com/0ff1c62147403c78af7be4edaec99a544bf15987
Cr-Commit-Position: refs/heads/master@{#437298}
==========