Embedding-CSP: Fixing path matching

Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588
Committed: https://crrev.com/910dbb06389a97ef582641437c3115290d5b1468
Cr-Commit-Position: refs/heads/master@{#437568}

[amalika, 2016-12-07 16:07:45]

amalika@google.com changed reviewers:
+ jochen@chromium.org, mkwst@chromium.org

[Mike West, 2016-12-08 08:25:52]

LGTM % testing nit.

https://codereview.chromium.org/2550093005/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/csp/CSPSource.cpp (right):

https://codereview.chromium.org/2550093005/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/csp/CSPSource.cpp:77: if (m_path.isEmpty()
|| (m_path == "/" && urlPath.isEmpty()))
Can you add a test to `CSPSourceTest.cpp`?

[amalika, 2016-12-08 09:01:59]

https://codereview.chromium.org/2550093005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2550093005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:199: {{"http", "/",
80}, {"https", "", 443}, false, true},
This also tests when A and B are swapped. Would this be sufficient or a separate
CSPSourceTest is necessary?

[amalika, 2016-12-08 19:29:48]

Patchset #3 (id:40001) has been deleted

[amalika, 2016-12-08 19:30:56]

The CQ bit was checked by amalika@google.com to run a CQ dry run

[amalika, 2016-12-08 19:31:00]

https://codereview.chromium.org/2550093005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPSource.cpp (right):

https://codereview.chromium.org/2550093005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPSource.cpp:159: m_path.length() >
other->m_path.length() ? m_path : other->m_path;
Simplified the logic instead of adding another check.

https://codereview.chromium.org/2550093005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp (right):

https://codereview.chromium.org/2550093005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/csp/CSPSourceTest.cpp:56:
TEST_F(CSPSourceTest, BasicPathMatching) {
Added path matching test

[commit-bot: I haz the power, 2016-12-08 19:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 21:09:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 21:09:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[amalika, 2016-12-09 11:44:56]

Description was changed from

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647688
==========

to

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588
==========

[amalika, 2016-12-09 16:54:06]

The CQ bit was checked by amalika@google.com

[amalika, 2016-12-09 16:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2550093005/#ps60001
(title: "Adding CSPSourceTest")

[commit-bot: I haz the power, 2016-12-09 16:54:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:01:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481302446041230,
"parent_rev": "9cf202c9fa096f7627c8debe0128c100566f8c7b", "commit_rev":
"37fcaa854fe2e882b49045389fb95daf13413aff"}

[commit-bot: I haz the power, 2016-12-09 17:03:50]

Description was changed from

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588
==========

to

==========

==========

[commit-bot: I haz the power, 2016-12-09 17:03:51]

Committed patchset #3 (id:60001)

[tandrii(chromium), 2016-12-12 14:35:27]

Description was changed from

==========

==========

to

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588
==========

[commit-bot: I haz the power, 2016-12-12 14:35:32]

Description was changed from

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588
==========

to

==========
Embedding-CSP: Fixing path matching

For example if we have "http://example.com/" and "http://example.com",
then their paths should match.

BUG=647588

Committed: https://crrev.com/910dbb06389a97ef582641437c3115290d5b1468
Cr-Commit-Position: refs/heads/master@{#437568}
==========

[commit-bot: I haz the power, 2016-12-12 14:35:34]

Patchset 3 (id:??) landed as
https://crrev.com/910dbb06389a97ef582641437c3115290d5b1468
Cr-Commit-Position: refs/heads/master@{#437568}