Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 255513005: Make DescriptorArray::IsMoreGeneralThan() and DescriptorArray::Merge() compatible again. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer
Modified:
6 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Make DescriptorArray::IsMoreGeneralThan() and DescriptorArray::Merge() compatible again. BUG=365172 LOG=y TEST=mjsunit/regress/regress-365172-[1-3] R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20922

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M src/objects.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-365172-1.js View 1 chunk +8 lines, -6 lines 0 comments Download
A test/mjsunit/regress/regress-365172-2.js View 1 chunk +13 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-365172-3.js View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
6 years, 8 months ago (2014-04-24 07:55:56 UTC) #1
Sven Panne
lgtm
6 years, 8 months ago (2014-04-24 08:06:25 UTC) #2
Benedikt Meurer
6 years, 8 months ago (2014-04-24 08:07:28 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20922 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698