Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: src/objects.cc

Issue 255513005: Make DescriptorArray::IsMoreGeneralThan() and DescriptorArray::Merge() compatible again. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-365172-1.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 95b2b062866bf71c34a0a3d416e77cdfed8d5b41..224f71a840d256fa5291de968465aa494b9ba52c 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -8520,6 +8520,10 @@ bool DescriptorArray::IsMoreGeneralThan(int verbatim,
if (details.type() == CONSTANT) {
if (other_details.type() != CONSTANT) return false;
if (GetValue(descriptor) != other->GetValue(descriptor)) return false;
+ } else if (details.type() == FIELD && other_details.type() == FIELD) {
+ if (!other->GetFieldType(descriptor)->NowIs(GetFieldType(descriptor))) {
+ return false;
+ }
}
}
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-365172-1.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698