Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: ash/wm/overview/scoped_transform_overview_window.cc

Issue 25551002: Fix visibility of minimized panels when restoring from overview. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/overview/scoped_transform_overview_window.cc
diff --git a/ash/wm/overview/scoped_transform_overview_window.cc b/ash/wm/overview/scoped_transform_overview_window.cc
index d596ccce4a9ba282aa84e3db1342af5eac856088..c561453fecd17cee4ab9495a3e80a3dd1884decd 100644
--- a/ash/wm/overview/scoped_transform_overview_window.cc
+++ b/ash/wm/overview/scoped_transform_overview_window.cc
@@ -186,6 +186,10 @@ ScopedTransformOverviewWindow::~ScopedTransformOverviewWindow() {
// bounds to the minimized position.
window_->layer()->SetOpacity(0);
window_->Hide();
+ // Hiding the window does not update the layer visibility because opacity
+ // is animating to 0 (See VisibilityController::UpdateLayerVisibility).
+ // Showing the window later requires that the layer visibility is false.
+ window_->layer()->SetVisible(false);
flackr 2013/10/01 16:09:12 This is really a workaround. I described the full
window_->SetProperty(aura::client::kShowStateKey,
ui::SHOW_STATE_MINIMIZED);
}
« no previous file with comments | « no previous file | ash/wm/overview/window_selector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698