Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2555043004: Remove ContextLifecycleObserer from XHRReplayData (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserer from XHRReplayData XHRReplayData inherits from ContextLifecycleObserer just to track ExecutionContext. It should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/9a2f35081ced906786154065184f84d36df818c7 Cr-Commit-Position: refs/heads/master@{#436933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.h View 4 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 11:18:46 UTC) #2
sof
lgtm
4 years ago (2016-12-07 12:04:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2555043004/1
4 years ago (2016-12-07 12:12:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 13:48:22 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 13:50:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9a2f35081ced906786154065184f84d36df818c7
Cr-Commit-Position: refs/heads/master@{#436933}

Powered by Google App Engine
This is Rietveld 408576698