Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp

Issue 2555043004: Remove ContextLifecycleObserer from XHRReplayData (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/NetworkResourcesData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
index 89b751538085166dd2f2f59339d20e06ed896149..6a4fb950adc483ec9953fdcde644b081ff27d3bb 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
@@ -1311,7 +1311,7 @@ Response InspectorNetworkAgent::replayXHR(const String& requestId) {
return Response::Error("Given id does not correspond to XHR");
ExecutionContext* executionContext = xhrReplayData->getExecutionContext();
- if (!executionContext) {
+ if (executionContext->isContextDestroyed()) {
m_resourcesData->setXHRReplayData(requestId, 0);
return Response::Error("Document is already detached");
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/inspector/NetworkResourcesData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698