Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Issue 255503004: Do not attempt to download favicons with 404 status in WebView (Closed)

Created:
6 years, 8 months ago by cimamoglu (inactive)
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Do not attempt to download favicons with 404 status in WebView This issue was fixed for Chromium (crbug.com/39402). This patch gets the relevant parts of the fixing patch for Android WebView. BUG=39402 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267192

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adds a test #

Total comments: 6

Patch Set 3 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -6 lines) Patch
M android_webview/browser/icon_helper.h View 3 chunks +11 lines, -0 lines 0 comments Download
M android_webview/browser/icon_helper.cc View 1 5 chunks +33 lines, -2 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java View 1 2 4 chunks +36 lines, -0 lines 0 comments Download
M android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java View 1 chunk +1 line, -0 lines 0 comments Download
M net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java View 1 4 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
cimamoglu (inactive)
6 years, 8 months ago (2014-04-24 15:25:08 UTC) #1
cimamoglu (inactive)
PTAL? (will create the external bug tomorrow -- need to leave now)
6 years, 8 months ago (2014-04-24 15:25:47 UTC) #2
mkosiba (inactive)
lgtm https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc File android_webview/browser/icon_helper.cc (right): https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc#newcode102 android_webview/browser/icon_helper.cc:102: ClearUnableToDownloadFavicons(); just curious - why don't we want ...
6 years, 8 months ago (2014-04-24 15:42:44 UTC) #3
cimamoglu (inactive)
The original downstream bug description specifically defines the problem as "WebView tries to fetch favicon.ico ...
6 years, 8 months ago (2014-04-24 18:45:45 UTC) #4
benm (inactive)
On 2014/04/24 18:45:45, cimamoglu wrote: > The original downstream bug description specifically defines the problem ...
6 years, 8 months ago (2014-04-24 18:52:53 UTC) #5
benm (inactive)
https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc File android_webview/browser/icon_helper.cc (right): https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc#newcode119 android_webview/browser/icon_helper.cc:119: nit: double new line
6 years, 8 months ago (2014-04-24 19:03:20 UTC) #6
cimamoglu (inactive)
+pliard for TestWebServer changes. Added a test and updated TestWebServer for the needs of the ...
6 years, 7 months ago (2014-04-28 10:39:58 UTC) #7
cimamoglu (inactive)
https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc File android_webview/browser/icon_helper.cc (right): https://codereview.chromium.org/255503004/diff/1/android_webview/browser/icon_helper.cc#newcode102 android_webview/browser/icon_helper.cc:102: ClearUnableToDownloadFavicons(); On 2014/04/24 15:42:44, mkosiba wrote: > just curious ...
6 years, 7 months ago (2014-04-28 10:41:03 UTC) #8
Philippe
LGTM for the changes in net/test/android/.
6 years, 7 months ago (2014-04-28 10:45:23 UTC) #9
benm (inactive)
https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java (right): https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java#newcode141 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java:141: Thread.sleep(MAX_REQUEST_WAITING_LIMIT_MS); why do we need this? The synchronous load ...
6 years, 7 months ago (2014-04-28 16:18:45 UTC) #10
mkosiba (inactive)
https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java (right): https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java#newcode44 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java:44: private static final int MAX_REQUEST_WAITING_LIMIT_MS = 500; import static ...
6 years, 7 months ago (2014-04-28 16:43:44 UTC) #11
cimamoglu (inactive)
https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java File android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java (right): https://codereview.chromium.org/255503004/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java#newcode44 android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java:44: private static final int MAX_REQUEST_WAITING_LIMIT_MS = 500; On 2014/04/28 ...
6 years, 7 months ago (2014-04-28 17:08:11 UTC) #12
benm (inactive)
lgtm thanks!
6 years, 7 months ago (2014-04-29 15:11:28 UTC) #13
cimamoglu (inactive)
The CQ bit was checked by cimamoglu@chromium.org
6 years, 7 months ago (2014-04-29 15:12:15 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/255503004/40001
6 years, 7 months ago (2014-04-29 15:12:40 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-29 21:30:21 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium
6 years, 7 months ago (2014-04-29 21:30:22 UTC) #17
cimamoglu (inactive)
The CQ bit was checked by cimamoglu@chromium.org
6 years, 7 months ago (2014-04-30 10:33:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/255503004/40001
6 years, 7 months ago (2014-04-30 10:35:07 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 12:11:02 UTC) #20
Message was sent while issue was closed.
Change committed as 267192

Powered by Google App Engine
This is Rietveld 408576698