android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java - Issue 255503004: Do not attempt to download favicons with 404 status in WebView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

Issue 255503004: Do not attempt to download favicons with 404 status in WebView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientFaviconTest.java ('k') | net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

diff --git a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

index 4042c872c963c748b8cbabf8a5984af46c819115..a30a72d459c0d545a873faa57d42684e836e9477 100644

--- a/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

+++ b/android_webview/test/shell/src/org/chromium/android_webview/shell/AwShellActivity.java

@@ -74,6 +74,7 @@ public class AwShellActivity extends Activity {

}

mAwTestContainerView.getAwContents().loadUrl(new LoadUrlParams(startupUrl));

+ AwContents.setShouldDownloadFavicons();

mUrlTextView.setText(startupUrl);

}