Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2554953005: Avoid WTF::Vector::at() and operator[] in core/events. (Closed)

Created:
4 years ago by tkent
Modified:
4 years ago
Reviewers:
hayato
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid WTF::Vector::at() and operator[] in core/events. at() and operator[] are slow due to RELEASE_ASSERT. We can avoid the slowness by range-based |for|. This CL has no behavior changes except runtime performance. BUG=668300 Committed: https://crrev.com/3ef1f1798c1964f6f20b009971ee843b1ab02bc3 Cr-Commit-Position: refs/heads/master@{#437083}

Patch Set 1 : _ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -33 lines) Patch
M third_party/WebKit/Source/core/events/EventPath.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventSender.h View 2 chunks +9 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTarget.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/events/ScopedEventQueue.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/events/TreeScopeEventContext.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/events/UIEventWithKeyState.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
tkent
hayato@, would you review this please?
4 years ago (2016-12-07 08:48:23 UTC) #9
hayato
lgtm
4 years ago (2016-12-07 09:25:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554953005/20001
4 years ago (2016-12-07 21:55:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-07 22:18:24 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-07 22:22:13 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ef1f1798c1964f6f20b009971ee843b1ab02bc3
Cr-Commit-Position: refs/heads/master@{#437083}

Powered by Google App Engine
This is Rietveld 408576698