Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2554953005: Avoid WTF::Vector::at() and operator[] in core/events. (Closed)
Patch Set: _ Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 6 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org> 7 * (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
8 * 8 *
9 * Redistribution and use in source and binary forms, with or without 9 * Redistribution and use in source and binary forms, with or without
10 * modification, are permitted provided that the following conditions 10 * modification, are permitted provided that the following conditions
(...skipping 349 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 size_t indexOfRemovedListener; 360 size_t indexOfRemovedListener;
361 RegisteredEventListener registeredListener; 361 RegisteredEventListener registeredListener;
362 362
363 if (!d->eventListenerMap.remove(eventType, listener, options, 363 if (!d->eventListenerMap.remove(eventType, listener, options,
364 &indexOfRemovedListener, &registeredListener)) 364 &indexOfRemovedListener, &registeredListener))
365 return false; 365 return false;
366 366
367 // Notify firing events planning to invoke the listener at 'index' that 367 // Notify firing events planning to invoke the listener at 'index' that
368 // they have one less listener to invoke. 368 // they have one less listener to invoke.
369 if (d->firingEventIterators) { 369 if (d->firingEventIterators) {
370 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) { 370 for (const auto& firingIterator : *d->firingEventIterators) {
371 FiringEventIterator& firingIterator = d->firingEventIterators->at(i);
372 if (eventType != firingIterator.eventType) 371 if (eventType != firingIterator.eventType)
373 continue; 372 continue;
374 373
375 if (indexOfRemovedListener >= firingIterator.end) 374 if (indexOfRemovedListener >= firingIterator.end)
376 continue; 375 continue;
377 376
378 --firingIterator.end; 377 --firingIterator.end;
379 // Note that when firing an event listener, 378 // Note that when firing an event listener,
380 // firingIterator.iterator indicates the next event listener 379 // firingIterator.iterator indicates the next event listener
381 // that would fire, not the currently firing event 380 // that would fire, not the currently firing event
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 742
744 void EventTarget::removeAllEventListeners() { 743 void EventTarget::removeAllEventListeners() {
745 EventTargetData* d = eventTargetData(); 744 EventTargetData* d = eventTargetData();
746 if (!d) 745 if (!d)
747 return; 746 return;
748 d->eventListenerMap.clear(); 747 d->eventListenerMap.clear();
749 748
750 // Notify firing events planning to invoke the listener at 'index' that 749 // Notify firing events planning to invoke the listener at 'index' that
751 // they have one less listener to invoke. 750 // they have one less listener to invoke.
752 if (d->firingEventIterators) { 751 if (d->firingEventIterators) {
753 for (size_t i = 0; i < d->firingEventIterators->size(); ++i) { 752 for (const auto& iterator : *d->firingEventIterators) {
754 d->firingEventIterators->at(i).iterator = 0; 753 iterator.iterator = 0;
755 d->firingEventIterators->at(i).end = 0; 754 iterator.end = 0;
756 } 755 }
757 } 756 }
758 } 757 }
759 758
760 } // namespace blink 759 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/events/EventSender.h ('k') | third_party/WebKit/Source/core/events/ScopedEventQueue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698