Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2554773002: CC Animation: Rename Active Players to Ticking Players. (Closed)

Created:
4 years ago by loyso (OOO)
Modified:
4 years ago
CC:
ajuma+watch_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-platform-graphics_chromium.org, Rik, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbauman+watch_chromium.org, jbroman, Justin Novosad, kalyank, pdr+graphicswatchlist_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CC Animation: Rename Active Players to Ticking Players. To avoid confusion with active/pending trees in LTH and tree activation process. BUG=669755 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Committed: https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b Cr-Commit-Position: refs/heads/master@{#436834}

Patch Set 1 #

Patch Set 2 : Rename the argument. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+350 lines, -354 lines) Patch
M cc/animation/animation_host.h View 4 chunks +11 lines, -11 lines 0 comments Download
M cc/animation/animation_host.cc View 5 chunks +30 lines, -33 lines 0 comments Download
M cc/animation/animation_player.h View 4 chunks +7 lines, -7 lines 0 comments Download
M cc/animation/animation_player.cc View 7 chunks +18 lines, -18 lines 0 comments Download
M cc/animation/animation_player_unittest.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/animation/element_animations.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M cc/animation/element_animations.cc View 1 6 chunks +11 lines, -10 lines 0 comments Download
M cc/animation/element_animations_unittest.cc View 95 chunks +222 lines, -224 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/blink/web_layer_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/animation_timelines_test_common.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/animation_timelines_test_common.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_in_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M cc/trees/mutator_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
loyso (OOO)
4 years ago (2016-12-06 22:10:23 UTC) #7
ajuma
lgtm, thanks for cleaning this up!!
4 years ago (2016-12-06 22:54:51 UTC) #8
loyso (OOO)
aelias@chromium.org - public platform (please) jbroman@chromium.org - Source platform, please!
4 years ago (2016-12-06 23:06:40 UTC) #10
jbroman
Source/platform/ rs lgtm
4 years ago (2016-12-06 23:08:20 UTC) #11
aelias_OOO_until_Jul13
lgtm
4 years ago (2016-12-06 23:13:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554773002/20001
4 years ago (2016-12-07 00:20:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-07 02:08:19 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-07 02:10:17 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a90a138797c24f8e19811717962f66b67388d97b
Cr-Commit-Position: refs/heads/master@{#436834}

Powered by Google App Engine
This is Rietveld 408576698