Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2554753005: Fix install-sysroot.py script not working behind proxy. (Closed)

Created:
4 years ago by darktears
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix install-sysroot.py script not working behind proxy. This is a regression from https://codereview.chromium.org/2538833006. urllib is usually pretty flaky with reading env variables to get the proxy url. urllib2 does a much better job. BUG= Committed: https://crrev.com/3d4239679d76e88774843f9dd2a132fcead3b24e Cr-Commit-Position: refs/heads/master@{#436761}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
darktears
4 years ago (2016-12-06 20:59:29 UTC) #2
Dirk Pranke
lgtm . I'll take your word for it ...
4 years ago (2016-12-06 21:04:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554753005/1
4 years ago (2016-12-06 22:11:59 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-06 22:30:41 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-06 22:34:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d4239679d76e88774843f9dd2a132fcead3b24e
Cr-Commit-Position: refs/heads/master@{#436761}

Powered by Google App Engine
This is Rietveld 408576698