Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2538833006: Remove wget usage from install-sysroot.py (Closed)

Created:
4 years ago by Tom (Use chromium acct)
Modified:
4 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove wget usage from install-sysroot.py CL https://codereview.chromium.org/2398633004/ used wget instead of curl to download the sysroots because it was more standard. However, not even wget is bundled with some freshly-installed distros, so just use python's urllib to download the sysroot tarballs directly. BUG=650482 R=dpranke@chromium.org Committed: https://crrev.com/3a7e078c89ca15736fed29638f2207494801572f Cr-Commit-Position: refs/heads/master@{#435753}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Tom (Use chromium acct)
Hopefully this time I got it right ¯\_(ツ)_/¯
4 years ago (2016-12-01 23:05:24 UTC) #3
Dirk Pranke
lgtm
4 years ago (2016-12-01 23:11:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2538833006/1
4 years ago (2016-12-01 23:14:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-01 23:23:54 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a7e078c89ca15736fed29638f2207494801572f Cr-Commit-Position: refs/heads/master@{#435753}
4 years ago (2016-12-01 23:27:04 UTC) #12
darktears
4 years ago (2016-12-06 20:58:56 UTC) #13
Message was sent while issue was closed.
On 2016/12/01 at 23:27:04, commit-bot wrote:
> Patchset 1 (id:??) landed as
https://crrev.com/3a7e078c89ca15736fed29638f2207494801572f
> Cr-Commit-Position: refs/heads/master@{#435753}

This commit breaks people behind proxies for example us at Intel. Despite we set
the http_proxy and https_proxy env variable on Linux it fails to download the
toolchain.

Proposed fix : https://codereview.chromium.org/2554753005

Powered by Google App Engine
This is Rietveld 408576698