Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2554753002:
Move the "Cast..." menu item in macOS menu bar from File to View (Closed)
DescriptionMove the "Cast..." menu item in macOS menu bar from File to View
Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item
to the View section. It will be placed after "Zoom Out" and before "Developer."
It will also have separators before and after it.
BUG=671483
Committed: https://crrev.com/db72fe0effc167be825c9243ca986c2da67d1aa3
Cr-Commit-Position: refs/heads/master@{#437610}
Patch Set 1 #
Messages
Total messages: 23 (15 generated)
Description was changed from ========== . BUG= ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, we're moving the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ==========
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, we're moving the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, we're moving the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ==========
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, we're moving the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ==========
Patchset #1 (id:1) has been deleted
takumif@chromium.org changed reviewers: + apacible@chromium.org, rsesek@chromium.org
Please take a look, thanks!
Is the CL description correct? I don't have an Encoding menu in View.
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Encoding" and "Developer." It will also have separators before and after it. BUG=671483 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 ==========
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 ==========
On 2016/12/08 23:22:13, Robert Sesek wrote: > Is the CL description correct? I don't have an Encoding menu in View. Oops, it seems Encoding was removed in M55, and I was looking at M54 while writing the description. Updated the description.
lgtm
lgtm
The CQ bit was checked by takumif@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by takumif@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481311304141350,
"parent_rev": "f051714a6587951c0ef89f87dd131a8ca9251a46", "commit_rev":
"ae61645a01d545c73d9e4170e202377b371dce37"}
Message was sent while issue was closed.
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 Review-Url: https://codereview.chromium.org/2554753002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 Review-Url: https://codereview.chromium.org/2554753002 ========== to ========== Move the "Cast..." menu item in macOS menu bar from File to View Per our discussion with shrike@ and hwi@, this CL moves the "Cast..." menu item to the View section. It will be placed after "Zoom Out" and before "Developer." It will also have separators before and after it. BUG=671483 Committed: https://crrev.com/db72fe0effc167be825c9243ca986c2da67d1aa3 Cr-Commit-Position: refs/heads/master@{#437610} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/db72fe0effc167be825c9243ca986c2da67d1aa3 Cr-Commit-Position: refs/heads/master@{#437610} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
