Avoid double paint offset of SVGForeignObject visual rect

Avoid double paint offset of SVGForeignObject visual rect

SVG object's local visual rects (from SVGLayoutSupport::localVisualRect)
are in their local svg coordinates in which paint offset doesn't apply.
Don't adjust non-root SVG object's local visual rect by paint offset
when calculating their visual rects in backing.

TEST=virtual/spinvalidation/paint/invalidation/svg/text-rescale.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/d4803657efd7d006ff8bf6f17091fb45e2e8ef34
Cr-Commit-Position: refs/heads/master@{#436978}

[Xianzhu, 2016-12-06 03:41:32]

Description was changed from

==========
Avoid double paint offset of SVGForeignObject visual rect

SVG object's local visual rects (from SVGLayoutSupport::localVisualRect)
are in their local svg coordinates in which paint offset doesn't apply.
Don't adjust non-root SVG object's local visual rect by paint offset
when calculating their visual rects in backing.

TEST=virtual/spinvalidation/paint/invalidation/svg/text-rescale.html
BUG=646176
==========

to

==========
Avoid double paint offset of SVGForeignObject visual rect

SVG object's local visual rects (from SVGLayoutSupport::localVisualRect)
are in their local svg coordinates in which paint offset doesn't apply.
Don't adjust non-root SVG object's local visual rect by paint offset
when calculating their visual rects in backing.

TEST=virtual/spinvalidation/paint/invalidation/svg/text-rescale.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2016-12-06 03:41:34]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 03:41:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 04:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 04:29:49]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-12-06 18:35:26]

wangxianzhu@chromium.org changed reviewers:
+ pdr@chromium.org

[Xianzhu, 2016-12-06 18:35:26]

https://codereview.chromium.org/2554743002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (left):

https://codereview.chromium.org/2554743002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:90: if
((!object.isSVG() || object.isSVGRoot()) && !rect.isEmpty()) {
!rect.isEmpty() is removed to be consistent with the non-spinvalidation path
(https://codereview.chromium.org/2545573002/).

[Xianzhu, 2016-12-06 18:35:37]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 18:36:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 19:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:18:19]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-12-06 19:21:32]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 19:21:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pdr., 2016-12-06 19:25:48]

On 2016/12/06 at 18:35:26, wangxianzhu wrote:
>
https://codereview.chromium.org/2554743002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/paint/PaintInvalidator.cpp (left):
> 
>
https://codereview.chromium.org/2554743002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/paint/PaintInvalidator.cpp:90: if
((!object.isSVG() || object.isSVGRoot()) && !rect.isEmpty()) {
> !rect.isEmpty() is removed to be consistent with the non-spinvalidation path
(https://codereview.chromium.org/2545573002/).

LGTM

[Xianzhu, 2016-12-06 19:32:40]

The CQ bit was unchecked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-06 19:32:40]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-06 19:33:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:14:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 20:14:18]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_layout_te...)

[Xianzhu, 2016-12-06 22:22:10]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:23:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 22:29:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 22:29:26]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Xianzhu, 2016-12-06 22:53:57]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 22:54:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 00:45:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 00:45:39]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Xianzhu, 2016-12-07 01:17:56]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-07 01:17:56]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2554743002/#ps100001
(title: "Rebaseline bugzilla-5669.html")

[commit-bot: I haz the power, 2016-12-07 01:18:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:18:17]

This CL has an open dependency (Issue 2556803004 Patch 40001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Xianzhu, 2016-12-07 01:21:08]

The CQ bit was checked by wangxianzhu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 01:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 01:38:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:38:06]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Xianzhu, 2016-12-07 01:38:52]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-07 01:39:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 02:40:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 02:40:59]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xianzhu, 2016-12-07 03:32:46]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2016-12-07 03:32:47]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2554743002/#ps120001
(title: "Rebaseline bugzilla-5669.html")

[commit-bot: I haz the power, 2016-12-07 03:33:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 05:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 05:34:32]

Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[Xianzhu, 2016-12-07 16:33:18]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:33:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 16:39:08]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1481128398465810,
"parent_rev": "a62390df0484d30dbdab075c3ed9dc23f95ce7bb", "commit_rev":
"588fd0df3a96860d1dc847fefef03e950d9dc185"}

[commit-bot: I haz the power, 2016-12-07 16:39:41]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-12-07 16:42:07]

Description was changed from

==========
Avoid double paint offset of SVGForeignObject visual rect

SVG object's local visual rects (from SVGLayoutSupport::localVisualRect)
are in their local svg coordinates in which paint offset doesn't apply.
Don't adjust non-root SVG object's local visual rect by paint offset
when calculating their visual rects in backing.

TEST=virtual/spinvalidation/paint/invalidation/svg/text-rescale.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Avoid double paint offset of SVGForeignObject visual rect

SVG object's local visual rects (from SVGLayoutSupport::localVisualRect)
are in their local svg coordinates in which paint offset doesn't apply.
Don't adjust non-root SVG object's local visual rect by paint offset
when calculating their visual rects in backing.

TEST=virtual/spinvalidation/paint/invalidation/svg/text-rescale.html
BUG=646176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Committed: https://crrev.com/d4803657efd7d006ff8bf6f17091fb45e2e8ef34
Cr-Commit-Position: refs/heads/master@{#436978}
==========

[commit-bot: I haz the power, 2016-12-07 16:42:08]

Patchset 7 (id:??) landed as
https://crrev.com/d4803657efd7d006ff8bf6f17091fb45e2e8ef34
Cr-Commit-Position: refs/heads/master@{#436978}