Use presentation attributes in HTMLMarquee

Use presentation attributes in HTMLMarquee

- Override isPresentationAttribute and collectStyleForPresentationAttribute
- Move "width: -webkit-fill-available" to UA stylesheet as styles set in shadow root have a higher precedence over presentation attribute styles
- Remove attributeChanged & attributeChangedCallback

BUG=669656
Committed: https://crrev.com/1e00d09a950c2a264e3e53fd0b40c7c7727175fb
Cr-Commit-Position: refs/heads/master@{#437004}

[adithyas, 2016-12-06 19:43:04]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[adithyas, 2016-12-06 19:43:09]

The CQ bit was unchecked by adithyas@chromium.org

[adithyas, 2016-12-06 19:43:34]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 19:44:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 20:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 20:45:18]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[adithyas, 2016-12-06 20:58:31]

adithyas@chromium.org changed reviewers:
+ esprehn@chromium.org, jbroman@chromium.org

[adithyas, 2016-12-06 20:58:32]

This is a follow-up to http://crrev.com/2549443003, cleaning up how CSS styles
that are determined by marquee HTML attributes are set/updated.

[jbroman, 2016-12-06 21:04:10]

lgtm with one comment

Please do wait for esprehn to approve as well, in case there's something more
subtle about the style rule precedence that I'm issing.

https://codereview.chromium.org/2554573005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp (right):

https://codereview.chromium.org/2554573005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:181: return
HTMLElement::Element::isPresentationAttribute(attr);
HTMLElement::isPresentationAttribute(attr) should suffice.

[haraken, 2016-12-06 23:43:18]

LGTM on my side

[esprehn, 2016-12-07 00:10:25]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[esprehn, 2016-12-07 00:10:26]

tkent@ plz look.

[tkent, 2016-12-07 00:27:34]

lgtm

[adithyas, 2016-12-07 16:30:46]

The CQ bit was checked by adithyas@chromium.org

[commit-bot: I haz the power, 2016-12-07 16:31:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-12-07 16:32:14]

The CQ bit was unchecked by jbroman@chromium.org

[adithyas, 2016-12-07 16:35:29]

https://codereview.chromium.org/2554573005/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp (right):

https://codereview.chromium.org/2554573005/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:181: return
HTMLElement::Element::isPresentationAttribute(attr);
On 2016/12/06 at 21:04:10, jbroman wrote:
> HTMLElement::isPresentationAttribute(attr) should suffice.

Oops, fixed.

[adithyas, 2016-12-07 16:36:30]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2016-12-07 16:36:31]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2554573005/#ps60001
(title: "Fix call to isPresentationAttribute")

[commit-bot: I haz the power, 2016-12-07 16:37:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 18:06:26]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481128590929130,
"parent_rev": "99061434f9d41be8566157d1a82503c035a817e5", "commit_rev":
"0d55c9f74a7d1fa2b73fe660eb2cd2a359c62011"}

[commit-bot: I haz the power, 2016-12-07 18:06:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-07 18:09:04]

Description was changed from

==========
Use presentation attributes in HTMLMarquee

- Override isPresentationAttribute and collectStyleForPresentationAttribute
- Move "width: -webkit-fill-available" to UA stylesheet as styles set in shadow
root have a higher precedence over presentation attribute styles
- Remove attributeChanged & attributeChangedCallback

BUG=669656
==========

to

==========
Use presentation attributes in HTMLMarquee

- Override isPresentationAttribute and collectStyleForPresentationAttribute
- Move "width: -webkit-fill-available" to UA stylesheet as styles set in shadow
root have a higher precedence over presentation attribute styles
- Remove attributeChanged & attributeChangedCallback

BUG=669656

Committed: https://crrev.com/1e00d09a950c2a264e3e53fd0b40c7c7727175fb
Cr-Commit-Position: refs/heads/master@{#437004}
==========

[commit-bot: I haz the power, 2016-12-07 18:09:05]

Patchset 4 (id:??) landed as
https://crrev.com/1e00d09a950c2a264e3e53fd0b40c7c7727175fb
Cr-Commit-Position: refs/heads/master@{#437004}