Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Unified Diff: third_party/WebKit/Source/core/html/HTMLMarqueeElement.h

Issue 2554573005: Use presentation attributes in HTMLMarquee (Closed)
Patch Set: Fix call to isPresentationAttribute Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLMarqueeElement.h
diff --git a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.h b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.h
index 325643a9bd4f4af8ffaf57e6ce7ad8a8f78f0c46..a423e736930f7e0d20f2bbd19746fdc69037247c 100644
--- a/third_party/WebKit/Source/core/html/HTMLMarqueeElement.h
+++ b/third_party/WebKit/Source/core/html/HTMLMarqueeElement.h
@@ -39,10 +39,6 @@ class HTMLMarqueeElement final : public HTMLElement {
static HTMLMarqueeElement* create(Document&);
- void attributeChanged(const QualifiedName&,
- const AtomicString& oldValue,
- const AtomicString& newValue,
- AttributeModificationReason) final;
InsertionNotificationRequest insertedInto(ContainerNode*) final;
void removedFrom(ContainerNode*) final;
@@ -64,6 +60,11 @@ class HTMLMarqueeElement final : public HTMLElement {
explicit HTMLMarqueeElement(Document&);
void didAddUserAgentShadowRoot(ShadowRoot&) override;
+ bool isPresentationAttribute(const QualifiedName&) const override;
+ void collectStyleForPresentationAttribute(const QualifiedName&,
+ const AtomicString&,
+ MutableStylePropertySet*) override;
+
class RequestAnimationFrameCallback final : public FrameRequestCallback {
WTF_MAKE_NONCOPYABLE(RequestAnimationFrameCallback);
@@ -116,9 +117,6 @@ class HTMLMarqueeElement final : public HTMLElement {
double marqueeHeight;
};
- void attributeChangedCallback(const QualifiedName& attr,
- const String& newValue);
-
StringKeyframeEffectModel* createEffectModel(AnimationParameters&);
void continueAnimation();
« no previous file with comments | « third_party/WebKit/Source/core/css/html.css ('k') | third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698