Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 255453003: Let Selection.deleteFromDocument not delete a character when the selection is a caret. (Closed)

Created:
6 years, 9 months ago by yoichio
Modified:
6 years, 9 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Let Selection.deleteFromDocument not delete a character when the selection is a caret. Selection.deleteFromDocument delete a character when the selection is a caret. However, current standard says that Selection.deleteFromDocument does nothing when the selection is a caret: https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-deletefromdocument Both IE10 and FireFox seem following the spec. BUG=366498, 362110 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172511

Patch Set 1 #

Total comments: 11

Patch Set 2 : use shouldBeEqualToString instead of shouldBe #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -47 lines) Patch
M LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/editing/selection/deleteFromDocument.html View 1 5 chunks +10 lines, -37 lines 0 comments Download
M LayoutTests/editing/selection/deleteFromDocument-expected.txt View 1 1 chunk +8 lines, -6 lines 0 comments Download
A LayoutTests/editing/selection/deleteFromDocument-undo-crash.html View 1 chunk +30 lines, -0 lines 0 comments Download
A + LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
yoichio
6 years, 9 months ago (2014-04-24 05:05:01 UTC) #1
Yuta Kitamura
I think this is a good change, but want to hear Yoshi's opinion, too. The ...
6 years, 9 months ago (2014-04-24 06:27:48 UTC) #2
yoichio
On 2014/04/24 06:27:48, Yuta Kitamura wrote: > I think this is a good change, but ...
6 years, 9 months ago (2014-04-24 06:33:02 UTC) #3
yosin_UTC9
SGTM; please update test script. Here is my reasoning: 1. Make compatible with other browsers: ...
6 years, 9 months ago (2014-04-24 06:39:58 UTC) #4
yoichio
> Note: actual issue of issue 362110 isn't solve this patch. ClusterFuzz will hit > ...
6 years, 9 months ago (2014-04-24 07:05:55 UTC) #5
yoichio
The CQ bit was checked by yoichio@chromium.org
6 years, 9 months ago (2014-04-24 07:11:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/255453003/20001
6 years, 9 months ago (2014-04-24 07:11:53 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-04-24 07:56:18 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-04-24 07:56:18 UTC) #9
yoichio
The CQ bit was checked by yoichio@chromium.org
6 years, 9 months ago (2014-04-24 14:38:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/255453003/20001
6 years, 9 months ago (2014-04-24 14:38:38 UTC) #11
commit-bot: I haz the power
6 years, 9 months ago (2014-04-24 15:20:50 UTC) #12
Message was sent while issue was closed.
Change committed as 172511

Powered by Google App Engine
This is Rietveld 408576698