Let Selection.deleteFromDocument not delete a character when the selection is a caret.

Let Selection.deleteFromDocument not delete a character when the selection is a caret.

Selection.deleteFromDocument delete a character when the selection is a caret.
However, current standard says that Selection.deleteFromDocument does nothing when the selection is a caret:
https://dvcs.w3.org/hg/editing/raw-file/tip/editing.html#dom-selection-deletefromdocument

Both IE10 and FireFox seem following the spec.

BUG=366498, 362110
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172511

[Yuta Kitamura, 2014-04-24 06:27:48]

I think this is a good change, but want to hear
Yoshi's opinion, too.

The change itself LGTM.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
File LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt
(right):

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt:1:
PASS. Blink didn't crash.
What happened to this file?

[yoichio, 2014-04-24 06:33:02]

On 2014/04/24 06:27:48, Yuta Kitamura wrote:
> I think this is a good change, but want to hear
> Yoshi's opinion, too.
> 
> The change itself LGTM.
> 
>
https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
> File LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt
> (right):
> 
>
https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
> LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt:1:
> PASS. Blink didn't crash.
> What happened to this file?

I'm not sure about the Rietveld behavior. Rietveld takes the file as a copy from
another file?
http://src.chromium.org/viewvc/blink/trunk/LayoutTests/editing/execCommand/ex...

[yosin_UTC9, 2014-04-24 06:39:58]

SGTM; please update test script.

Here is my reasoning:
1. Make compatible with other browsers: +1 => Web developers don't need to write
polyfill. 
2. Follow specification: +1 => Chrome follows standard.

Note: actual issue of issue 362110 isn't solve this patch. ClusterFuzz will hit
this AV by another test case.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
File LayoutTests/editing/selection/deleteFromDocument.html (right):

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:23:
shouldBe('span1.textContent', "'foobar'");
nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:32:
shouldBe('span1.textContent', "'foobar'");
nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:42:
shouldBe('span1.firstChild.nextSibling.id', "'span2'");
nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:43:
shouldBe('span1.firstChild.nextSibling.firstChild.nodeValue', "''");
nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:52:
shouldBe('test.textContent', "'fz'");
nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

[yoichio, 2014-04-24 07:05:55]

> Note: actual issue of issue 362110 isn't solve this patch. ClusterFuzz will
hit
> this AV by another test case.
What's the word 'AV'?

The issue362110 reveals two problem:
1. document.execCommand("Undo") following selection.deleteFromDocument brakes
context including the selection.
2. document.execCommand('InsertText') under broken context can cause crash.

This patch fixes a part of problem #1.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
File LayoutTests/editing/selection/deleteFromDocument.html (right):

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:23:
shouldBe('span1.textContent', "'foobar'");
On 2014/04/24 06:39:58, Yoshi wrote:
> nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

Done.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:32:
shouldBe('span1.textContent', "'foobar'");
On 2014/04/24 06:39:58, Yoshi wrote:
> nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

Done.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:42:
shouldBe('span1.firstChild.nextSibling.id', "'span2'");
On 2014/04/24 06:39:58, Yoshi wrote:
> nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

Done.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:43:
shouldBe('span1.firstChild.nextSibling.firstChild.nodeValue', "''");
On 2014/04/24 06:39:58, Yoshi wrote:
> nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

Done.

https://codereview.chromium.org/255453003/diff/1/LayoutTests/editing/selectio...
LayoutTests/editing/selection/deleteFromDocument.html:52:
shouldBe('test.textContent', "'fz'");
On 2014/04/24 06:39:58, Yoshi wrote:
> nit: Please use ShouldBeEqualToString(expr, string) avoid quotes.

Done.

[yoichio, 2014-04-24 07:11:35]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2014-04-24 07:11:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/255453003/20001

[commit-bot: I haz the power, 2014-04-24 07:56:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-24 07:56:18]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[yoichio, 2014-04-24 14:38:21]

The CQ bit was checked by yoichio@chromium.org

[commit-bot: I haz the power, 2014-04-24 14:38:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoichio@chromium.org/255453003/20001

[commit-bot: I haz the power, 2014-04-24 15:20:50]

Change committed as 172511