LayoutTests/editing/selection/deleteFromDocument-undo-crash.html - Issue 255453003: Let Selection.deleteFromDocument not delete a character when the selection is a caret.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/deleteFromDocument-undo-crash.html

Issue 255453003: Let Selection.deleteFromDocument not delete a character when the selection is a caret. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: use shouldBeEqualToString instead of shouldBe Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/editing/selection/deleteFromDocument-expected.txt ('k') | LayoutTests/editing/selection/deleteFromDocument-undo-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script id="script1"></script>

	4 <script>

	5 if (window.testRunner)

	6 testRunner.dumpAsText();

	7

	8 window.onload = function () {

	9 document.designMode = "on";

	10 var selection = window.getSelection();

	11 document.execCommand("SelectAll", false)

	12 var range = selection.getRangeAt(0);

	13

	14 range.insertNode(document.getElementById("script1"));

	15 document.execCommand('InsertText', false, 'efgh');

	16 document.execCommand('JustifyFull', false, false);

	17

	18 selection.deleteFromDocument();

	19 document.execCommand("Undo", false, false);

	20

	21 document.execCommand("Delete");

	22

	23 document.documentElement.innerHTML = "PASS. Blink didn't crash.";

	24 };

	25 </script>

	26 </head>

	27 <body>

	28 <h1>abcd</h1>

	29 </body>

	30 </html>

OLD	NEW