Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2554493002:
[x86] [crankshaft] unify jump label's distance value in DoWrapReceiver(). (Closed)
|
Created:
4 years ago by zhengxing.li Modified:
4 years ago CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[x86] [crankshaft] unify jump label's distance value in DoWrapReceiver().
Currently the jump label's distance value in LCodeGen::DoWrapReceiver() of X86 is unconsistent.
For avoiding potential bugs caused by this unconsistent usage for the same label when DeoptEveryNTimes()
return true, This CL unify the label's distance value usage in LCodeGen::DoWrapReceiver().
For more informations, please refer CL #41419 (https://codereview.chromium.org/2539403002/ ).
BUG=
Committed: https://crrev.com/493d48d8a62e041b5b01213676bd3ba9e941558c
Cr-Commit-Position: refs/heads/master@{#41659}
Patch Set 1 #
Messages
Total messages: 22 (8 generated)
zhengxing.li@intel.com changed reviewers: + bmeurer@chromium.org, titzer@chromium.org
PTAL, thanks!
On 2016/12/05 11:02:45, zhengxing.li wrote: > PTAL, thanks! Anyone have time to take a look at this CL? Thanks!
lgtm
On 2016/12/06 14:45:45, titzer wrote: > lgtm Thanks!
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30090)
On 2016/12/06 14:50:49, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > v8_presubmit on master.tryserver.v8 (JOB_FAILED, > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30090) Looks like you need a crankshaft owner.
On 2016/12/06 14:52:39, titzer wrote: > On 2016/12/06 14:50:49, commit-bot: I haz the power wrote: > > Try jobs failed on following builders: > > v8_presubmit on master.tryserver.v8 (JOB_FAILED, > > http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30090) > > Looks like you need a crankshaft owner. Got it, Thanks titzer!
zhengxing.li@intel.com changed reviewers: + jarin@chromium.org
PTAL, thanks!
On 2016/12/06 14:57:38, zhengxing.li wrote: > PTAL, thanks! Hi, bmeurer or Jarin: Would you please take a look at this CL if you are available? This CL needs a crankshaft owner's LGTM. Thanks!
lgtm
The CQ bit was checked by zhengxing.li@intel.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481592507695250, "parent_rev":
"2cb50037c263b8c670517657dacb2ab7a64279a0", "commit_rev":
"4ee177ad5e8bdee303cf6494dfcf10831f296d82"}
Message was sent while issue was closed.
Description was changed from ========== [x86] [crankshaft] unify jump label's distance value in DoWrapReceiver(). Currently the jump label's distance value in LCodeGen::DoWrapReceiver() of X86 is unconsistent. For avoiding potential bugs caused by this unconsistent usage for the same label when DeoptEveryNTimes() return true, This CL unify the label's distance value usage in LCodeGen::DoWrapReceiver(). For more informations, please refer CL #41419 (https://codereview.chromium.org/2539403002/ ). BUG= ========== to ========== [x86] [crankshaft] unify jump label's distance value in DoWrapReceiver(). Currently the jump label's distance value in LCodeGen::DoWrapReceiver() of X86 is unconsistent. For avoiding potential bugs caused by this unconsistent usage for the same label when DeoptEveryNTimes() return true, This CL unify the label's distance value usage in LCodeGen::DoWrapReceiver(). For more informations, please refer CL #41419 (https://codereview.chromium.org/2539403002/ ). BUG= Review-Url: https://codereview.chromium.org/2554493002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [x86] [crankshaft] unify jump label's distance value in DoWrapReceiver(). Currently the jump label's distance value in LCodeGen::DoWrapReceiver() of X86 is unconsistent. For avoiding potential bugs caused by this unconsistent usage for the same label when DeoptEveryNTimes() return true, This CL unify the label's distance value usage in LCodeGen::DoWrapReceiver(). For more informations, please refer CL #41419 (https://codereview.chromium.org/2539403002/ ). BUG= Review-Url: https://codereview.chromium.org/2554493002 ========== to ========== [x86] [crankshaft] unify jump label's distance value in DoWrapReceiver(). Currently the jump label's distance value in LCodeGen::DoWrapReceiver() of X86 is unconsistent. For avoiding potential bugs caused by this unconsistent usage for the same label when DeoptEveryNTimes() return true, This CL unify the label's distance value usage in LCodeGen::DoWrapReceiver(). For more informations, please refer CL #41419 (https://codereview.chromium.org/2539403002/ ). BUG= Committed: https://crrev.com/493d48d8a62e041b5b01213676bd3ba9e941558c Cr-Commit-Position: refs/heads/master@{#41659} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/493d48d8a62e041b5b01213676bd3ba9e941558c Cr-Commit-Position: refs/heads/master@{#41659} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
