[regexp] Move helper functions to custom assembler

[regexp] Move helper functions to custom assembler

This moves all helper functions to the RegExpBuiltinsAssembler together
with some follow-up cleanups for:

* consistent function names,
* consistent parameter names and order,
* removal of global CVariable and CLabel typedefs.

BUG=v8:5339
Committed: https://crrev.com/d0eb8f91b3cd5644fa7abfe2d96a466ff74aa249
Cr-Commit-Position: refs/heads/master@{#41493}

[jgruber, 2016-12-05 08:39:10]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-05 08:39:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2016-12-05 09:19:03]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org

[commit-bot: I haz the power, 2016-12-05 09:32:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 09:32:30]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-12-05 09:52:11]

LGTM, maybe move all the helpers to the beginning of the file.
As discussed offline, having all the helpers inline is maybe more confusing.

https://codereview.chromium.org/2554453003/diff/1/src/builtins/builtins-regex...
File src/builtins/builtins-regexp.cc (right):

https://codereview.chromium.org/2554453003/diff/1/src/builtins/builtins-regex...
src/builtins/builtins-regexp.cc:95: Node*
RegExpBuiltinsAssembler::FastLoadLastIndex(Node* regexp) {
I'd directly define them inline to avoid declaring the arguments again.

[jgruber, 2016-12-05 15:47:21]

On 2016/12/05 09:52:11, Camillo Bruni wrote:
> LGTM, maybe move all the helpers to the beginning of the file.
> As discussed offline, having all the helpers inline is maybe more confusing.

Yup, I think I'd prefer keeping it as-is since the declarations are a nice
summary of available functions. I did not move the functions around within the
file to keep the diff somewhat readable.

[jgruber, 2016-12-05 15:47:24]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2016-12-05 15:47:25]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2554453003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2016-12-05 15:47:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 16:12:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480952844744490,
"parent_rev": "fab2ead11f25b1bfd229d69af7e215290182355d", "commit_rev":
"48850cd078fdb8d1cc7f2b31f227bfd1ff33e230"}

[commit-bot: I haz the power, 2016-12-05 16:12:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-05 16:13:33]

Description was changed from

==========
[regexp] Move helper functions to custom assembler

This moves all helper functions to the RegExpBuiltinsAssembler together
with some follow-up cleanups for:

* consistent function names,
* consistent parameter names and order,
* removal of global CVariable and CLabel typedefs.

BUG=v8:5339
==========

to

==========
[regexp] Move helper functions to custom assembler

This moves all helper functions to the RegExpBuiltinsAssembler together
with some follow-up cleanups for:

* consistent function names,
* consistent parameter names and order,
* removal of global CVariable and CLabel typedefs.

BUG=v8:5339

Committed: https://crrev.com/d0eb8f91b3cd5644fa7abfe2d96a466ff74aa249
Cr-Commit-Position: refs/heads/master@{#41493}
==========

[commit-bot: I haz the power, 2016-12-05 16:13:34]

Patchset 2 (id:??) landed as
https://crrev.com/d0eb8f91b3cd5644fa7abfe2d96a466ff74aa249
Cr-Commit-Position: refs/heads/master@{#41493}