Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2543243002: [regexp] Convert builtins to TF_BUILTIN macro (Closed)

Created:
4 years ago by jgruber
Modified:
4 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] Convert builtins to TF_BUILTIN macro BUG=v8:5339 Committed: https://crrev.com/eb6a8adabdc9adc8e5e8d5f249ba129f0995e21c Cr-Commit-Position: refs/heads/master@{#41491}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+294 lines, -319 lines) Patch
M src/builtins/builtins-regexp.cc View 1 10 chunks +294 lines, -319 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
jgruber
I'll move helper methods in the next CL to reduce noise.
4 years ago (2016-12-02 14:23:45 UTC) #4
Camillo Bruni
LGTM with nit https://codereview.chromium.org/2543243002/diff/1/src/builtins/builtins-regexp.cc File src/builtins/builtins-regexp.cc (right): https://codereview.chromium.org/2543243002/diff/1/src/builtins/builtins-regexp.cc#newcode18 src/builtins/builtins-regexp.cc:18: typedef CodeStubAssembler::Variable CVariable; You can drop ...
4 years ago (2016-12-02 15:09:53 UTC) #7
jgruber
https://codereview.chromium.org/2543243002/diff/1/src/builtins/builtins-regexp.cc File src/builtins/builtins-regexp.cc (right): https://codereview.chromium.org/2543243002/diff/1/src/builtins/builtins-regexp.cc#newcode18 src/builtins/builtins-regexp.cc:18: typedef CodeStubAssembler::Variable CVariable; On 2016/12/02 15:09:53, Camillo Bruni wrote: ...
4 years ago (2016-12-05 12:30:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2543243002/20001
4 years ago (2016-12-05 14:01:17 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 14:29:25 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-05 14:29:55 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb6a8adabdc9adc8e5e8d5f249ba129f0995e21c
Cr-Commit-Position: refs/heads/master@{#41491}

Powered by Google App Engine
This is Rietveld 408576698