Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6241)

Unified Diff: chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc

Issue 255443002: Implement argument validation for chrome.cast.channel.{open,send} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto upstream Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc
diff --git a/chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc b/chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc
index 631e2998e9f5025d32dd59517ed64db0c7f9bdf8..e736f16dd4cfe64eb57e240b93024a862b89ab38 100644
--- a/chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc
+++ b/chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc
@@ -46,7 +46,7 @@ TEST(CastChannelOpenFunctionTest, TestParseChannelUrl) {
EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://192.0.0.1:"), &connect_info));
}
-// Tests validation of ConnectInfo.
+// Tests parsing of ConnectInfo.
TEST(CastChannelOpenFunctionTest, TestParseConnectInfo) {
typedef CastChannelOpenFunction ccof;
scoped_ptr<net::IPEndPoint> ip_endpoint;
@@ -60,30 +60,6 @@ TEST(CastChannelOpenFunctionTest, TestParseConnectInfo) {
ip_endpoint.reset(ccof::ParseConnectInfo(connect_info));
EXPECT_TRUE(ip_endpoint.get() != NULL);
EXPECT_EQ(ip_endpoint->ToString(), "192.0.0.1:8009");
-
- // Invalid IP
- ConnectInfo invalid_ip_connect_info;
- invalid_ip_connect_info.ip_address = "blargh";
- invalid_ip_connect_info.port = 8009;
- invalid_ip_connect_info.auth = CHANNEL_AUTH_TYPE_SSL;
- ip_endpoint.reset(ccof::ParseConnectInfo(invalid_ip_connect_info));
- EXPECT_TRUE(ip_endpoint.get() == NULL);
-
- // Invalid port
- ConnectInfo invalid_port_connect_info;
- invalid_port_connect_info.ip_address = "192.0.0.1";
- invalid_port_connect_info.port = -1;
- invalid_port_connect_info.auth = CHANNEL_AUTH_TYPE_SSL;
- ip_endpoint.reset(ccof::ParseConnectInfo(invalid_port_connect_info));
- EXPECT_TRUE(ip_endpoint.get() == NULL);
-
- // Invalid auth
- ConnectInfo invalid_auth_connect_info;
- invalid_auth_connect_info.ip_address = "192.0.0.1";
- invalid_auth_connect_info.port = 8009;
- invalid_auth_connect_info.auth = CHANNEL_AUTH_TYPE_NONE;
- ip_endpoint.reset(ccof::ParseConnectInfo(invalid_auth_connect_info));
- EXPECT_TRUE(ip_endpoint.get() == NULL);
}
} // namespace cast_channel

Powered by Google App Engine
This is Rietveld 408576698