Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/browser/extensions/api/cast_channel/cast_channel_api_unittest.cc

Issue 255443002: Implement argument validation for chrome.cast.channel.{open,send} (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase onto upstream Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/cast_channel/cast_channel_api.h" 5 #include "chrome/browser/extensions/api/cast_channel/cast_channel_api.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "net/base/ip_endpoint.h" 8 #include "net/base/ip_endpoint.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "url/gurl.h" 10 #include "url/gurl.h"
(...skipping 28 matching lines...) Expand all
39 &connect_info)); 39 &connect_info));
40 EXPECT_FALSE(ccof::ParseChannelUrl(GURL(""), &connect_info)); 40 EXPECT_FALSE(ccof::ParseChannelUrl(GURL(""), &connect_info));
41 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("foo"), &connect_info)); 41 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("foo"), &connect_info));
42 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast:"), &connect_info)); 42 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast:"), &connect_info));
43 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast::"), &connect_info)); 43 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast::"), &connect_info));
44 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://192.0.0.1"), &connect_info)); 44 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://192.0.0.1"), &connect_info));
45 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://:"), &connect_info)); 45 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://:"), &connect_info));
46 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://192.0.0.1:"), &connect_info)); 46 EXPECT_FALSE(ccof::ParseChannelUrl(GURL("cast://192.0.0.1:"), &connect_info));
47 } 47 }
48 48
49 // Tests validation of ConnectInfo. 49 // Tests parsing of ConnectInfo.
50 TEST(CastChannelOpenFunctionTest, TestParseConnectInfo) { 50 TEST(CastChannelOpenFunctionTest, TestParseConnectInfo) {
51 typedef CastChannelOpenFunction ccof; 51 typedef CastChannelOpenFunction ccof;
52 scoped_ptr<net::IPEndPoint> ip_endpoint; 52 scoped_ptr<net::IPEndPoint> ip_endpoint;
53 53
54 // Valid ConnectInfo 54 // Valid ConnectInfo
55 ConnectInfo connect_info; 55 ConnectInfo connect_info;
56 connect_info.ip_address = "192.0.0.1"; 56 connect_info.ip_address = "192.0.0.1";
57 connect_info.port = 8009; 57 connect_info.port = 8009;
58 connect_info.auth = CHANNEL_AUTH_TYPE_SSL; 58 connect_info.auth = CHANNEL_AUTH_TYPE_SSL;
59 59
60 ip_endpoint.reset(ccof::ParseConnectInfo(connect_info)); 60 ip_endpoint.reset(ccof::ParseConnectInfo(connect_info));
61 EXPECT_TRUE(ip_endpoint.get() != NULL); 61 EXPECT_TRUE(ip_endpoint.get() != NULL);
62 EXPECT_EQ(ip_endpoint->ToString(), "192.0.0.1:8009"); 62 EXPECT_EQ(ip_endpoint->ToString(), "192.0.0.1:8009");
63
64 // Invalid IP
65 ConnectInfo invalid_ip_connect_info;
66 invalid_ip_connect_info.ip_address = "blargh";
67 invalid_ip_connect_info.port = 8009;
68 invalid_ip_connect_info.auth = CHANNEL_AUTH_TYPE_SSL;
69 ip_endpoint.reset(ccof::ParseConnectInfo(invalid_ip_connect_info));
70 EXPECT_TRUE(ip_endpoint.get() == NULL);
71
72 // Invalid port
73 ConnectInfo invalid_port_connect_info;
74 invalid_port_connect_info.ip_address = "192.0.0.1";
75 invalid_port_connect_info.port = -1;
76 invalid_port_connect_info.auth = CHANNEL_AUTH_TYPE_SSL;
77 ip_endpoint.reset(ccof::ParseConnectInfo(invalid_port_connect_info));
78 EXPECT_TRUE(ip_endpoint.get() == NULL);
79
80 // Invalid auth
81 ConnectInfo invalid_auth_connect_info;
82 invalid_auth_connect_info.ip_address = "192.0.0.1";
83 invalid_auth_connect_info.port = 8009;
84 invalid_auth_connect_info.auth = CHANNEL_AUTH_TYPE_NONE;
85 ip_endpoint.reset(ccof::ParseConnectInfo(invalid_auth_connect_info));
86 EXPECT_TRUE(ip_endpoint.get() == NULL);
87 } 63 }
88 64
89 } // namespace cast_channel 65 } // namespace cast_channel
90 } // namespace api 66 } // namespace api
91 } // namespace extensions 67 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698