Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2554423005: [heap] Relax condition for forced finalization of incremental marking. (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Relax condition for forced finalization of incremental marking. Forcing finalization after reaching allocation limit regresses gc pause time in benchmarks as we have to do a lot of non-incremental marking work. This patch allows overshoot of the limit by some margin. BUG=chromium:670675, chromium:671994 TBR=mlippautz@chromium.org Committed: https://crrev.com/a6976211d1a4d12df815fa9ff5341dcbcf1e8036 Cr-Commit-Position: refs/heads/master@{#41625}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -2 lines) Patch
M src/heap/heap.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
ulan
ptal
4 years ago (2016-12-09 15:30:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554423005/1
4 years ago (2016-12-09 16:20:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 16:22:59 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-09 16:23:11 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6976211d1a4d12df815fa9ff5341dcbcf1e8036
Cr-Commit-Position: refs/heads/master@{#41625}

Powered by Google App Engine
This is Rietveld 408576698