Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 2554423004: [turbofan] Turn off escape analysis. (Closed)

Created:
4 years ago by Jarin
Modified:
4 years ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn off escape analysis. Too many crashes in Canary. Committed: https://crrev.com/54656518004cd7439b69d2e83ee7eabdec25daea Cr-Commit-Position: refs/heads/master@{#41612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Jarin
Could you take a look, please?
4 years ago (2016-12-09 09:37:08 UTC) #2
Tobias Tebbi
On 2016/12/09 09:37:08, Jarin wrote: > Could you take a look, please? lgtm
4 years ago (2016-12-09 09:38:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554423004/1
4 years ago (2016-12-09 09:44:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 10:14:43 UTC) #8
commit-bot: I haz the power
4 years ago (2016-12-09 10:15:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54656518004cd7439b69d2e83ee7eabdec25daea
Cr-Commit-Position: refs/heads/master@{#41612}

Powered by Google App Engine
This is Rietveld 408576698