Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2554403004: Make XSSAuditor more suspicious about start of path (Closed)

Created:
4 years ago by Tom Sepez
Modified:
4 years ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch, loading-reviews+parser_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make XSSAuditor more suspicious about start of path BUG=613123 Committed: https://crrev.com/fe1346fdca1dc967b9c1575a658bcc5930fe35fb Cr-Commit-Position: refs/heads/master@{#437574}

Patch Set 1 #

Patch Set 2 : run-on sentences in comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -13 lines) Patch
A third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-implied-host.html View 1 chunk +15 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/security/xssAuditor/script-tag-with-source-implied-host-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp View 1 2 chunks +41 lines, -13 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Tom Sepez
Mike, ready for review.
4 years ago (2016-12-08 23:04:22 UTC) #4
Mike West
Looks reasonable. LGTM.
4 years ago (2016-12-09 12:47:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554403004/20001
4 years ago (2016-12-09 17:16:48 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-09 17:25:25 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 14:35:47 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe1346fdca1dc967b9c1575a658bcc5930fe35fb
Cr-Commit-Position: refs/heads/master@{#437574}

Powered by Google App Engine
This is Rietveld 408576698