HTMLMarquee cleanup

HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of using String::format which is locale sensitive

BUG=669656
Committed: https://crrev.com/dc9cbaf3d7f45808a4cead119b804296b6edf1a8
Cr-Commit-Position: refs/heads/master@{#437569}

[adithyas, 2016-12-07 20:50:59]

Description was changed from

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Use getIntegralAttribute instead of toInt()
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()

BUG=669656
==========

to

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Use getIntegralAttribute instead of toInt()
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656
==========

[adithyas, 2016-12-07 21:01:30]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-07 21:02:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-07 22:44:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 22:44:34]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[adithyas, 2016-12-08 00:10:37]

Description was changed from

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Use getIntegralAttribute instead of toInt()
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656
==========

to

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656
==========

[adithyas, 2016-12-08 00:11:00]

The CQ bit was checked by adithyas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 00:11:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 01:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 01:10:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[adithyas, 2016-12-08 15:04:16]

adithyas@chromium.org changed reviewers:
+ jbroman@chromium.org, tkent@chromium.org

[adithyas, 2016-12-08 15:04:16]

tkent@: I've addressed most of your feedback from http://crrev.com/2549443003
here, could you PTAL?

[jbroman, 2016-12-08 15:15:03]

lgtm with one comment; tkent may have more feedback

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp (right):

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:85: void
handleEvent(double) override;
nit: now that the declaration and definition are both in the source file, you
might as well just put the definitions of handleEvent inline.

[tkent, 2016-12-09 01:18:03]

lgtm

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp (right):

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:332: if
(equalIgnoringCase(behavior, "alternate"))
Maybe equalIgnoringASCIICasae?

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:341: if
(equalIgnoringCase(direction, "down"))
Ditto.

[adithyas, 2016-12-09 15:35:06]

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp (right):

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:85: void
handleEvent(double) override;
On 2016/12/08 at 15:15:02, jbroman wrote:
> nit: now that the declaration and definition are both in the source file, you
might as well just put the definitions of handleEvent inline.

Makes sense.

https://codereview.chromium.org/2554403002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMarqueeElement.cpp:332: if
(equalIgnoringCase(behavior, "alternate"))
On 2016/12/09 at 01:18:03, tkent wrote:
> Maybe equalIgnoringASCIICasae?

Changed, here and below.

[adithyas, 2016-12-09 15:35:40]

The CQ bit was checked by adithyas@chromium.org

[adithyas, 2016-12-09 15:35:40]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2554403002/#ps100001
(title: "Code review changes")

[commit-bot: I haz the power, 2016-12-09 15:35:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:03:20]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1481297740306110,
"parent_rev": "37fcaa854fe2e882b49045389fb95daf13413aff", "commit_rev":
"0b553ed60ded2c3da408dfad1bdbca6dcb7601ce"}

[commit-bot: I haz the power, 2016-12-09 17:03:46]

Description was changed from

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656
==========

to

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656

Review-Url: https://codereview.chromium.org/2554403002
==========

[commit-bot: I haz the power, 2016-12-09 17:03:47]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-12 14:35:36]

Description was changed from

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive 

BUG=669656

Review-Url: https://codereview.chromium.org/2554403002
==========

to

==========
HTMLMarquee cleanup

- Follow up to http://crrev.com/2549443003
- Move RequestAnimationFrameCallback and AnimationComplete class
  definitions to .cpp file
- Prefix enums with k
- Change direction() and behavior() to getDirection() and getBehavior()
  respectively
- Use case insensitive match for direction and behavior
- Remove trueSpeed()
- Use String::numberToStringECMAScript to convert double to String instead of
using String::format which is locale sensitive

BUG=669656

Committed: https://crrev.com/dc9cbaf3d7f45808a4cead119b804296b6edf1a8
Cr-Commit-Position: refs/heads/master@{#437569}
==========

[commit-bot: I haz the power, 2016-12-12 14:35:37]

Patchset 6 (id:??) landed as
https://crrev.com/dc9cbaf3d7f45808a4cead119b804296b6edf1a8
Cr-Commit-Position: refs/heads/master@{#437569}