Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2554303002: Remove ContextLifecycleObserver from SpeechSynthesis (Closed)

Created:
4 years ago by haraken
Modified:
4 years ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextLifecycleObserver from SpeechSynthesis SpeechSynthesis is inherting from ContextLifecycleObserver just to track ExecutionContext. It should just hold a strong member to ExecutionContext. BUG=610176 Committed: https://crrev.com/816cfec11745623dbf9bb690c9aae85776712095 Cr-Commit-Position: refs/heads/master@{#436936}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.h View 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 4 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
haraken
PTAL
4 years ago (2016-12-07 11:55:04 UTC) #2
sof
lgtm
4 years ago (2016-12-07 12:06:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554303002/1
4 years ago (2016-12-07 12:12:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 13:53:07 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 13:55:04 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/816cfec11745623dbf9bb690c9aae85776712095
Cr-Commit-Position: refs/heads/master@{#436936}

Powered by Google App Engine
This is Rietveld 408576698