Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(946)

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesis.h

Issue 2554303002: Remove ContextLifecycleObserver from SpeechSynthesis (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/speech/SpeechSynthesis.h
diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.h b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.h
index 3094a4cfc7174e3ffe21b29f7d228f4b0b47e216..6363225e31ce7b9817dc8f986f0042d052e95383 100644
--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesis.h
+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesis.h
@@ -26,7 +26,6 @@
#ifndef SpeechSynthesis_h
#define SpeechSynthesis_h
-#include "core/dom/ContextLifecycleObserver.h"
#include "modules/EventTargetModules.h"
#include "modules/ModulesExport.h"
#include "modules/speech/SpeechSynthesisUtterance.h"
@@ -41,8 +40,7 @@ class PlatformSpeechSynthesizerClient;
class MODULES_EXPORT SpeechSynthesis final
: public EventTargetWithInlineData,
- public PlatformSpeechSynthesizerClient,
- public ContextLifecycleObserver {
+ public PlatformSpeechSynthesizerClient {
DEFINE_WRAPPERTYPEINFO();
USING_GARBAGE_COLLECTED_MIXIN(SpeechSynthesis);
@@ -65,7 +63,9 @@ class MODULES_EXPORT SpeechSynthesis final
DEFINE_ATTRIBUTE_EVENT_LISTENER(voiceschanged);
- ExecutionContext* getExecutionContext() const override;
+ ExecutionContext* getExecutionContext() const override {
+ return m_executionContext;
+ }
DECLARE_VIRTUAL_TRACE();
@@ -93,6 +93,7 @@ class MODULES_EXPORT SpeechSynthesis final
// Returns the utterance at the front of the queue.
SpeechSynthesisUtterance* currentSpeechUtterance() const;
+ Member<ExecutionContext> m_executionContext;
Member<PlatformSpeechSynthesizer> m_platformSpeechSynthesizer;
HeapVector<Member<SpeechSynthesisVoice>> m_voiceList;
HeapDeque<Member<SpeechSynthesisUtterance>> m_utteranceQueue;
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698