devtools: Make it possible to retrieve all cookies

devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932, 166637
Committed: https://crrev.com/b0512a0bd23b83a5a00c79fd1169b820f3673e04
Cr-Commit-Position: refs/heads/master@{#437246}

[Sami, 2016-12-07 10:56:22]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2016-12-07 10:56:35]

Description was changed from

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637
==========

to

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637
==========

[Sami, 2016-12-07 10:56:35]

skyostil@chromium.org changed reviewers:
+ dgozman@chromium.org

[commit-bot: I haz the power, 2016-12-07 10:56:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2016-12-07 10:57:08]

PTAL.

[commit-bot: I haz the power, 2016-12-07 11:53:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-07 11:53:02]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dgozman, 2016-12-07 19:25:05]

lgtm

https://codereview.chromium.org/2554293002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2554293002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1498:
EXPECT_TRUE(cookies->GetDictionary(0, &cookie));
Bots show that order is unpredictable here :-)

[Sami, 2016-12-08 10:52:10]

Thanks!

https://codereview.chromium.org/2554293002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/devtools_protocol_browsertest.cc (right):

https://codereview.chromium.org/2554293002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/devtools_protocol_browsertest.cc:1498:
EXPECT_TRUE(cookies->GetDictionary(0, &cookie));
On 2016/12/07 19:25:05, dgozman wrote:
> Bots show that order is unpredictable here :-)

So it seems :) Fixed.

[Sami, 2016-12-08 10:52:17]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-12-08 10:52:17]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2554293002/#ps20001
(title: "Make tests robust")

[commit-bot: I haz the power, 2016-12-08 10:52:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 13:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 13:26:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sami, 2016-12-08 13:56:02]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-12-08 13:56:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2554293002/#ps40001
(title: "Update front-end")

[commit-bot: I haz the power, 2016-12-08 13:56:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 15:14:21]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481205362544410,
"parent_rev": "f9efa73a15ffd548fb38542c7494df16adb6f0eb", "commit_rev":
"9931ff65c2427b02631d9654d6e4ddf08bb9a0c6"}

[commit-bot: I haz the power, 2016-12-08 15:14:51]

Description was changed from

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637
==========

to

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637
==========

[commit-bot: I haz the power, 2016-12-08 15:14:52]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-08 15:18:29]

Description was changed from

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637
==========

to

==========
devtools: Make it possible to retrieve all cookies

This patch adds a new "global" mode to the Network.getCookies command
which allows retrieving all cookies in the browser cookie jar instead of
just the cookies for the current URL.

BUG=668932,166637

Committed: https://crrev.com/b0512a0bd23b83a5a00c79fd1169b820f3673e04
Cr-Commit-Position: refs/heads/master@{#437246}
==========

[commit-bot: I haz the power, 2016-12-08 15:18:30]

Patchset 3 (id:??) landed as
https://crrev.com/b0512a0bd23b83a5a00c79fd1169b820f3673e04
Cr-Commit-Position: refs/heads/master@{#437246}

[pfeldman, 2016-12-09 02:42:02]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2016-12-09 02:42:03]

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:1231: { "name":
"global", "type": "boolean", "optional": true, "description": "If true, returns
all cookies, otherwise only the cookies for the current URL." }
Global sounds weird, present semantics is also unclear. I'd rather pass 'url'
here explicitly. if url is empty, all cookies should be returned.

[pfeldman, 2016-12-09 02:49:15]

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:286: { "name":
"cookies", "type": "array", "items": { "$ref": "Network.Cookie" },
"description": "Array of cookie objects." }
Missing parameter for redirect.

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:1231: { "name":
"global", "type": "boolean", "optional": true, "description": "If true, returns
all cookies, otherwise only the cookies for the current URL." }
Discussed it with dgozman@. Why don't we add another method getAllCookies
instead?

[Sami, 2016-12-09 14:32:50]

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/browser_protocol.json (right):

https://codereview.chromium.org/2554293002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/browser_protocol.json:1231: { "name":
"global", "type": "boolean", "optional": true, "description": "If true, returns
all cookies, otherwise only the cookies for the current URL." }
On 2016/12/09 02:49:15, pfeldman wrote:
> Discussed it with dgozman@. Why don't we add another method getAllCookies
> instead?

Sounds like a fine idea -- doing that here:
https://codereview.chromium.org/2568503002/