Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issue 2554273002: Unexport resource_controller.h (Closed)

Created:
4 years ago by tyoshino (SeeGerritForStatus)
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, asanka, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, loading-reviews_chromium.org, qsr+mojo_chromium.org, Randy Smith (Not in Mondays), viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Unexport resource_controller.h This is a follow up for https://codereview.chromium.org/2535723005/ suggested by mmenke@. ResourceController is no longer used by any file outside of content/browser/. Move it to content/browser/loader/. BUG=646277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Committed: https://crrev.com/3b3ee8e99fca8912ad38f2bdc6137189c5043790 Cr-Commit-Position: refs/heads/master@{#436967}

Patch Set 1 #

Patch Set 2 : Add resource_controller.h #

Patch Set 3 : browser_tests build #

Patch Set 4 : content_unittests build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -53 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/loader/DEPS View 7 chunks +4 lines, -5 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/detachable_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/intercepting_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/intercepting_resource_handler_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mime_sniffing_resource_handler_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/mojo_async_resource_handler_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/loader/navigation_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/redirect_to_file_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/loader/resource_controller.h View 1 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/loader/resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/stream_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/throttling_resource_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/browser/resource_controller.h View 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
tyoshino (SeeGerritForStatus)
4 years ago (2016-12-07 08:36:15 UTC) #7
tyoshino (SeeGerritForStatus)
Oops. Forgot to git add. PTAL at ps2.
4 years ago (2016-12-07 08:46:17 UTC) #12
tyoshino (SeeGerritForStatus)
On 2016/12/07 08:46:17, tyoshino wrote: > Oops. Forgot to git add. PTAL at ps2. Sorry ...
4 years ago (2016-12-07 09:09:42 UTC) #18
jochen (gone - plz use gerrit)
lgtm
4 years ago (2016-12-07 15:37:42 UTC) #21
mmenke
On 2016/12/07 15:37:42, jochen wrote: > lgtm LGTM, thanks for doing this!
4 years ago (2016-12-07 15:52:23 UTC) #22
mmenke
On 2016/12/07 15:52:23, mmenke wrote: > On 2016/12/07 15:37:42, jochen wrote: > > lgtm > ...
4 years ago (2016-12-07 15:58:48 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554273002/60001
4 years ago (2016-12-07 15:59:11 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-07 16:04:43 UTC) #27
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3b3ee8e99fca8912ad38f2bdc6137189c5043790 Cr-Commit-Position: refs/heads/master@{#436967}
4 years ago (2016-12-07 16:06:48 UTC) #29
tyoshino (SeeGerritForStatus)
4 years ago (2016-12-08 14:32:44 UTC) #30
Message was sent while issue was closed.
On 2016/12/07 15:58:48, mmenke wrote:
> On 2016/12/07 15:52:23, mmenke wrote:
> > On 2016/12/07 15:37:42, jochen wrote:
> > > lgtm
> > 
> > LGTM, thanks for doing this!
> 
> Going to go ahead and CQ this - as I mentioned, I'm doing some work here, and
> don't want our CLs to fight with each other.

Thanks!

Powered by Google App Engine
This is Rietveld 408576698