Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/3b3ee8e99fca8912ad38f2bdc6137189c5043790
Cr-Commit-Position: refs/heads/master@{#436967}
Description was changed from ========== Unexport resource_controller.h This is a follow up for https://codereview.chromium.org/2535723005/ ResourceController ...
Description was changed from
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
ResourceController is no longer used by any file outside of
content/browser/.
BUG=646277
==========
to
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
ResourceController is no longer used by any file outside of
content/browser/.
BUG=646277
==========
Description was changed from ========== Unexport resource_controller.h This is a follow up for https://codereview.chromium.org/2535723005/ ResourceController ...
Description was changed from
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
ResourceController is no longer used by any file outside of
content/browser/.
BUG=646277
==========
to
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
==========
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/176274) android_compile_dbg on ...
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/284180)
Description was changed from ========== Unexport resource_controller.h This is a follow up for https://codereview.chromium.org/2535723005/ suggested ...
Description was changed from
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
==========
to
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org to run a CQ dry run
On 2016/12/07 15:52:23, mmenke wrote:
> On 2016/12/07 15:37:42, jochen wrote:
> > lgtm
>
> LGTM, thanks for doing this!
Going to go ahead and CQ this - as I mentioned, I'm doing some work here, and
don't want our CLs to fight with each other.
Description was changed from ========== Unexport resource_controller.h This is a follow up for https://codereview.chromium.org/2535723005/ suggested ...
Description was changed from
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========
to
==========
Unexport resource_controller.h
This is a follow up for https://codereview.chromium.org/2535723005/
suggested by mmenke@.
ResourceController is no longer used by any file outside of
content/browser/. Move it to content/browser/loader/.
BUG=646277
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
Committed: https://crrev.com/3b3ee8e99fca8912ad38f2bdc6137189c5043790
Cr-Commit-Position: refs/heads/master@{#436967}
==========
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/3b3ee8e99fca8912ad38f2bdc6137189c5043790 Cr-Commit-Position: refs/heads/master@{#436967}
On 2016/12/07 15:58:48, mmenke wrote:
> On 2016/12/07 15:52:23, mmenke wrote:
> > On 2016/12/07 15:37:42, jochen wrote:
> > > lgtm
> >
> > LGTM, thanks for doing this!
>
> Going to go ahead and CQ this - as I mentioned, I'm doing some work here, and
> don't want our CLs to fight with each other.
Thanks!
Issue 2554273002: Unexport resource_controller.h
(Closed)
Created 4 years ago by tyoshino (SeeGerritForStatus)
Modified 4 years ago
Reviewers: jochen (gone - plz use gerrit), mmenke
Base URL:
Comments: 0