Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2554253002: bluetooth: web: Rename Blacklist to Blocklist (Closed)

Created:
4 years ago by ortuno
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

bluetooth: web: Rename Blacklist to Blocklist BUG=662106 Review-Url: https://codereview.chromium.org/2488283003 Cr-Commit-Position: refs/heads/master@{#434163} (cherry picked from commit 01135bffec64608e65c787ea0345691638831f5e) Committed: https://chromium.googlesource.com/chromium/src/+/d1210b726077a1522db654a2c027e7b466dc5257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -1473 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/web_bluetooth_browsertest.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/bluetooth/bluetooth_allowed_devices_map.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D content/browser/bluetooth/bluetooth_blacklist.h View 1 chunk +0 lines, -106 lines 0 comments Download
D content/browser/bluetooth/bluetooth_blacklist.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D content/browser/bluetooth/bluetooth_blacklist_unittest.cc View 1 chunk +0 lines, -487 lines 0 comments Download
A + content/browser/bluetooth/bluetooth_blocklist.h View 4 chunks +26 lines, -26 lines 0 comments Download
A + content/browser/bluetooth/bluetooth_blocklist.cc View 7 chunks +37 lines, -37 lines 0 comments Download
A + content/browser/bluetooth/bluetooth_blocklist_unittest.cc View 11 chunks +62 lines, -62 lines 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/bluetooth/bluetooth_device_chooser_controller.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/bluetooth/bluetooth_metrics.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/bluetooth/web_bluetooth_service_impl.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h View 6 chunks +13 lines, -13 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 6 chunks +19 lines, -19 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/blacklisted-characteristic.html View 1 chunk +0 lines, -22 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/blocklisted-characteristic.html View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blacklisted-characteristics-with-uuid.html View 1 chunk +0 lines, -23 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics.html View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/blocklisted-characteristics-with-uuid.html View 2 chunks +4 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blacklisted-services.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blacklisted-services-with-uuid.html View 1 chunk +0 lines, -21 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services.html View 2 chunks +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/getPrimaryServices/blocklisted-services-with-uuid.html View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/readValue/blacklisted-characteristic.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/readValue/blocklisted-characteristic.html View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/requestDevice/blacklisted-service-in-filter.html View 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/requestDevice/blacklisted-service-in-optionalServices.html View 1 chunk +0 lines, -27 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-filter.html View 1 chunk +4 lines, -4 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/requestDevice/blocklisted-service-in-optionalServices.html View 1 chunk +5 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/writeValue/blacklisted-characteristic.html View 1 chunk +0 lines, -26 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bluetooth/writeValue/blocklisted-characteristic.html View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py View 7 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 5 chunks +21 lines, -3 lines 0 comments Download
D tools/web_bluetooth/compact_blacklist.py View 1 chunk +0 lines, -113 lines 0 comments Download
D tools/web_bluetooth/compact_blacklist_unittest.py View 1 chunk +0 lines, -73 lines 0 comments Download
A + tools/web_bluetooth/compact_blocklist.py View 3 chunks +14 lines, -14 lines 0 comments Download
A + tools/web_bluetooth/compact_blocklist_unittest.py View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ortuno
4 years ago (2016-12-07 04:52:45 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d1210b726077a1522db654a2c027e7b466dc5257.

Powered by Google App Engine
This is Rietveld 408576698