bluetooth: web: Rename Blacklist to Blocklist

bluetooth: web: Rename Blacklist to Blocklist

BUG=662106
Committed: https://crrev.com/01135bffec64608e65c787ea0345691638831f5e
Cr-Commit-Position: refs/heads/master@{#434163}

[fbeaufortchromium, 2016-11-10 15:19:56]

The CQ bit was checked by fbeaufort@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 15:20:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 20:35:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 20:35:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[François Beaufort, 2016-11-14 08:41:12]

beaufort.francois@gmail.com changed reviewers:
+ ben@chromium.org, jochen@chromium.org, nasko@chromium.org, scheib@chromium.org
- fbeaufort@chromium.org

[François Beaufort, 2016-11-14 08:41:13]

Hello everyone,

Even though it looks like a big patch, this is as simple as replacing occurences
of Blacklist by Blocklist in Web Bluetooth code. 
TAG review included a request to avoid 'blacklist' as it can be offensive. See
https://github.com/WebBluetoothCG/web-bluetooth/issues/327

scheib, please review changes in:
  chrome/browser/web_bluetooth_browsertest.cc
  content/browser/bluetooth/bluetooth_allowed_devices_map.cc
  content/browser/bluetooth/bluetooth_blacklist.cc
  content/browser/bluetooth/bluetooth_blacklist.h
  content/browser/bluetooth/bluetooth_blacklist_unittest.cc
  content/browser/bluetooth/bluetooth_blocklist.cc
  content/browser/bluetooth/bluetooth_blocklist.h
  content/browser/bluetooth/bluetooth_blocklist_unittest.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.h
  content/browser/bluetooth/bluetooth_metrics.h
  content/browser/bluetooth/web_bluetooth_service_impl.cc
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
  third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
  third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py
  tools/web_bluetooth/compact_blacklist.py
  tools/web_bluetooth/compact_blacklist_unittest.py
  tools/web_bluetooth/compact_blocklist.py
  tools/web_bluetooth/compact_blocklist_unittest.py

jochen, please review changes in:
  chrome/browser/web_bluetooth_browsertest.cc
  content/browser/BUILD.gn
  content/browser/bluetooth/bluetooth_allowed_devices_map.cc
  content/browser/bluetooth/bluetooth_blacklist.cc
  content/browser/bluetooth/bluetooth_blacklist.h
  content/browser/bluetooth/bluetooth_blacklist_unittest.cc
  content/browser/bluetooth/bluetooth_blocklist.cc
  content/browser/bluetooth/bluetooth_blocklist.h
  content/browser/bluetooth/bluetooth_blocklist_unittest.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.h
  content/browser/bluetooth/bluetooth_metrics.h
  content/browser/bluetooth/web_bluetooth_service_impl.cc
  content/public/browser/content_browser_client.cc
  content/public/browser/content_browser_client.h
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
  third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
  third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py
  tools/metrics/histograms/histograms.xml

ben, please review changes in:
  chrome/browser/web_bluetooth_browsertest.cc
  content/browser/BUILD.gn
  content/browser/bluetooth/bluetooth_allowed_devices_map.cc
  content/browser/bluetooth/bluetooth_blacklist.cc
  content/browser/bluetooth/bluetooth_blacklist.h
  content/browser/bluetooth/bluetooth_blacklist_unittest.cc
  content/browser/bluetooth/bluetooth_blocklist.cc
  content/browser/bluetooth/bluetooth_blocklist.h
  content/browser/bluetooth/bluetooth_blocklist_unittest.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.h
  content/browser/bluetooth/bluetooth_metrics.h
  content/browser/bluetooth/web_bluetooth_service_impl.cc
  content/public/browser/content_browser_client.cc
  content/public/browser/content_browser_client.h
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
  testing/variations/fieldtrial_testing_config.json
  third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
  third_party/WebKit/Source/modules/bluetooth/testing/clusterfuzz/wbt_fakes.py
  tools/web_bluetooth/compact_blacklist.py
  tools/web_bluetooth/compact_blacklist_unittest.py
  tools/web_bluetooth/compact_blocklist.py
  tools/web_bluetooth/compact_blocklist_unittest.py

nasko, please review changes in:
  content/browser/BUILD.gn
  content/browser/bluetooth/bluetooth_allowed_devices_map.cc
  content/browser/bluetooth/bluetooth_blacklist.cc
  content/browser/bluetooth/bluetooth_blacklist.h
  content/browser/bluetooth/bluetooth_blacklist_unittest.cc
  content/browser/bluetooth/bluetooth_blocklist.cc
  content/browser/bluetooth/bluetooth_blocklist.h
  content/browser/bluetooth/bluetooth_blocklist_unittest.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.cc
  content/browser/bluetooth/bluetooth_device_chooser_controller.h
  content/browser/bluetooth/bluetooth_metrics.h
  content/browser/bluetooth/web_bluetooth_service_impl.cc
  content/public/browser/content_browser_client.cc
  content/public/browser/content_browser_client.h
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
  content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
  third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

[jochen (gone - plz use gerrit), 2016-11-14 17:52:23]

for the histograms.xml change, please ask somebody from the metrics team. I can
only approve use counter additions.

[nasko, 2016-11-14 20:39:18]

content/ rubberstamp LGTM

[ortuno, 2016-11-14 22:27:59]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[ortuno, 2016-11-14 22:29:39]

https://codereview.chromium.org/2488283003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js
(right):

https://codereview.chromium.org/2488283003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js:5:
var blocklist_test_service_uuid = "611c954a-263b-4f4a-aab6-01ddb953f985";
I believe these are imported from the Web Platform Tests repo and therefore
should be changed upstream.

[commit-bot: I haz the power, 2016-11-14 22:30:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-11-14 22:55:10]

LGTM excluding
third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js as
ortuno noted.

[commit-bot: I haz the power, 2016-11-15 01:10:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-15 01:10:11]

Dry run: This issue passed the CQ dry run.

[François Beaufort, 2016-11-15 14:12:45]

beaufort.francois@gmail.com changed reviewers:
- jochen@chromium.org

[François Beaufort, 2016-11-15 14:12:46]

I've removed 
third_party/WebKit/LayoutTests/imported/wpt/bluetooth/bluetooth-helpers.js and
started a PR for this at https://github.com/w3c/web-platform-tests/pull/4213

[François Beaufort, 2016-11-15 14:13:51]

beaufort.francois@gmail.com changed reviewers:
+ mkwst@chromium.org

[François Beaufort, 2016-11-15 14:13:51]

mkwst@chromium.org: Please review changes in 

tools/metrics/histograms/histograms.xml

[Mike West, 2016-11-17 14:22:47]

mkwst@chromium.org changed reviewers:
+ isherman@chromium.org

[Mike West, 2016-11-17 14:22:48]

Sorry, you'll need a real reviewer for histograms.xml, as I'm only in there for
UseCounter changes (and I'm honestly not sure what the impact of changing a
histogram's name actually is). Pulling in isherman@ in the hopes that you can
get more actionable feedback.

(The intent looks good to me, though).

[Ilya Sherman, 2016-11-18 00:12:05]

https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:4529: -<histogram
name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
Please mark the previous name as <obsolete>.  Also, are you comfortable with the
data discontinuity that will result from renaming this histogram?

[scheib, 2016-11-18 00:27:45]

https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:4529: -<histogram
name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
On 2016/11/18 00:12:05, Ilya Sherman wrote:
> Please mark the previous name as <obsolete>.  Also, are you comfortable with
the
> data discontinuity that will result from renaming this histogram?

Data discontinuity will be OK. We use this to validate that a field trial
parameter is successfully being parsed by our code in the wild - so we only need
it in the short term after deploying new parameters.

[François Beaufort, 2016-11-21 12:28:03]

On 2016/11/18 00:27:45, scheib wrote:
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (left):
> 
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:4529: -<histogram
> name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
> On 2016/11/18 00:12:05, Ilya Sherman wrote:
> > Please mark the previous name as <obsolete>.  Also, are you comfortable with
> the
> > data discontinuity that will result from renaming this histogram?
> 
> Data discontinuity will be OK. We use this to validate that a field trial
> parameter is successfully being parsed by our code in the wild - so we only
need
> it in the short term after deploying new parameters.

Ilya does that look good then?

[Ilya Sherman, 2016-11-21 18:29:38]

On 2016/11/21 12:28:03, François Beaufort wrote:
> On 2016/11/18 00:27:45, scheib wrote:
> >
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> > File tools/metrics/histograms/histograms.xml (left):
> > 
> >
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> > tools/metrics/histograms/histograms.xml:4529: -<histogram
> > name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
> > On 2016/11/18 00:12:05, Ilya Sherman wrote:
> > > Please mark the previous name as <obsolete>.  Also, are you comfortable
with
> > the
> > > data discontinuity that will result from renaming this histogram?
> > 
> > Data discontinuity will be OK. We use this to validate that a field trial
> > parameter is successfully being parsed by our code in the wild - so we only
> need
> > it in the short term after deploying new parameters.
> 
> Ilya does that look good then?

Not yet -- as I requested above, please mark the previous name as <obsolete>

[François Beaufort, 2016-11-22 08:14:18]

On 2016/11/21 18:29:38, Ilya Sherman wrote:
> On 2016/11/21 12:28:03, François Beaufort wrote:
> > On 2016/11/18 00:27:45, scheib wrote:
> > >
> >
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> > > File tools/metrics/histograms/histograms.xml (left):
> > > 
> > >
> >
>
https://codereview.chromium.org/2488283003/diff/40001/tools/metrics/histogram...
> > > tools/metrics/histograms/histograms.xml:4529: -<histogram
> > > name="Bluetooth.Web.Blacklist.ParsedNonEmptyString"
> > > On 2016/11/18 00:12:05, Ilya Sherman wrote:
> > > > Please mark the previous name as <obsolete>.  Also, are you comfortable
> with
> > > the
> > > > data discontinuity that will result from renaming this histogram?
> > > 
> > > Data discontinuity will be OK. We use this to validate that a field trial
> > > parameter is successfully being parsed by our code in the wild - so we
only
> > need
> > > it in the short term after deploying new parameters.
> > 
> > Ilya does that look good then?
> 
> Not yet -- as I requested above, please mark the previous name as <obsolete>

Done.
Thanks for the reminder Ilya.

[Ilya Sherman, 2016-11-22 22:26:26]

histograms.xml and the field trial testing config LGTM % a nit:

https://codereview.chromium.org/2488283003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2488283003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:4532: +    This histogram is deprecated
in 2016 November.
nit: Please mention which histogram replaces it.

[François Beaufort, 2016-11-23 07:33:58]

On 2016/11/22 22:26:26, Ilya Sherman wrote:
> histograms.xml and the field trial testing config LGTM % a nit:
> 
>
https://codereview.chromium.org/2488283003/diff/60001/tools/metrics/histogram...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/2488283003/diff/60001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:4532: +    This histogram is
deprecated
> in 2016 November.
> nit: Please mention which histogram replaces it.

Done.

[François Beaufort, 2016-11-23 08:05:11]

The CQ bit was checked by beaufort.francois@gmail.com

[François Beaufort, 2016-11-23 08:05:12]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
nasko@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488283003/#ps80001
(title: "Adjusted description")

[commit-bot: I haz the power, 2016-11-23 08:05:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 08:08:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 08:08:12]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[François Beaufort, 2016-11-23 08:35:30]

The CQ bit was checked by beaufort.francois@gmail.com

[François Beaufort, 2016-11-23 08:35:31]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
nasko@chromium.org, isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2488283003/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-23 08:35:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 09:30:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 09:30:30]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[François Beaufort, 2016-11-23 14:00:59]

The CQ bit was checked by beaufort.francois@gmail.com

[commit-bot: I haz the power, 2016-11-23 14:01:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 14:37:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1479909659161680,
"parent_rev": "c689e3e911b761ab288d83455b3151efea77a989", "commit_rev":
"6a23f50304f9f1c2ded9a29d45d11c748c94e848"}

[commit-bot: I haz the power, 2016-11-23 14:38:08]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-11-23 14:39:41]

Description was changed from

==========
bluetooth: web: Rename Blacklist to Blocklist

BUG=662106
==========

to

==========
bluetooth: web: Rename Blacklist to Blocklist

BUG=662106

Committed: https://crrev.com/01135bffec64608e65c787ea0345691638831f5e
Cr-Commit-Position: refs/heads/master@{#434163}
==========

[commit-bot: I haz the power, 2016-11-23 14:39:43]

Patchset 6 (id:??) landed as
https://crrev.com/01135bffec64608e65c787ea0345691638831f5e
Cr-Commit-Position: refs/heads/master@{#434163}