Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2554173002: DevTools: Fix SuggestBox not showing without a maximum height (Closed)

Created:
4 years ago by einbinder
Modified:
4 years ago
Reviewers:
dgozman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Fix SuggestBox not showing without a maximum height BUG=670581 Committed: https://crrev.com/60923e44a7116db275bf8c74b1cd52ba2335b1af Cr-Commit-Position: refs/heads/master@{#436775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
einbinder
ptal
4 years ago (2016-12-06 20:58:19 UTC) #2
dgozman
lgtm
4 years ago (2016-12-06 21:38:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2554173002/1
4 years ago (2016-12-06 22:07:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-07 00:28:14 UTC) #7
commit-bot: I haz the power
4 years ago (2016-12-07 00:32:03 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/60923e44a7116db275bf8c74b1cd52ba2335b1af
Cr-Commit-Position: refs/heads/master@{#436775}

Powered by Google App Engine
This is Rietveld 408576698