Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js

Issue 2554173002: DevTools: Fix SuggestBox not showing without a maximum height (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
index 23cd78d8e052ac698921deabb084e643665b4fe9..cc55b44f5de00918f8cc4246ec0a2215f70e2991 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js
@@ -126,7 +126,8 @@ UI.SuggestBox = class {
var spacer = 6;
var maxHeight = Math.min(
- Math.max(underHeight, aboveHeight) - spacer, this._maxItemsHeight ? this._maxItemsHeight * this._rowHeight : 0);
+ Math.max(underHeight, aboveHeight) - spacer,
+ this._maxItemsHeight ? this._maxItemsHeight * this._rowHeight : Infinity);
var height = this._rowHeight * this._items.length;
this._hasVerticalScroll = height > maxHeight;
this._element.style.height = Math.min(maxHeight, height) + 'px';
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698