Chromium Code Reviews| Index: appengine/findit/handlers/flake/triage_flake_analysis.py |
| diff --git a/appengine/findit/handlers/flake/triage_flake_analysis.py b/appengine/findit/handlers/flake/triage_flake_analysis.py |
| index 7670f080a359edc29d8e71ce41350e6f2ac801f4..9430ba2231bacdbbc948015b5c3cd0c016bafbc7 100644 |
| --- a/appengine/findit/handlers/flake/triage_flake_analysis.py |
| +++ b/appengine/findit/handlers/flake/triage_flake_analysis.py |
| @@ -40,9 +40,13 @@ class TriageFlakeAnalysis(BaseHandler): |
| def HandleGet(self): # pragma: no cover |
| """Sets the manual triage result for the suspected flake analysis.""" |
| - flake_info = self.request.get('flake_info') |
| - (master_name, builder_name, build_number, step_name, test_name, |
| - version_number, suspected_build_number) = flake_info.split('/') |
| + master_name = self.request.get('master_name').strip() |
| + builder_name = self.request.get('builder_name').strip() |
| + build_number = self.request.get('build_number').strip() |
| + step_name = self.request.get('step_name').strip() |
| + test_name = self.request.get('test_name').strip() |
| + version_number = self.request.get('version_number').strip() |
|
stgao
2016/12/07 20:12:50
Would it be easier if we use the key.urlsafe() jus
chanli
2016/12/07 20:56:12
Agreed.
lijeffrey
2016/12/07 22:02:03
That's much cleaner! Done.
|
| + suspected_build_number = self.request.get('suspected_build_number').strip() |
| triage_result = self.request.get('triage_result') |
| if not (master_name and builder_name and build_number and step_name and |