[Findit] Using master flake analysis key for updating triage results

appengine/findit/handlers/flake/triage_flake_analysis.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module is to handle manual triage of a suspected flake result.
 
 This handler will mark the suspected flake result as correct or incorrect.
 """
 
 from google.appengine.api import users
@@ skipping 22 matching lines @@
   master_flake_analysis.put()
   return True
 
 
 class TriageFlakeAnalysis(BaseHandler):
   PERMISSION_LEVEL = Permission.CORP_USER
   LOGIN_REDIRECT_TO_DISTINATION_PAGE_FOR_GET = False
 
   def HandleGet(self):  # pragma: no cover
     """Sets the manual triage result for the suspected flake analysis."""
-    flake_info = self.request.get('flake_info')
-    (master_name, builder_name, build_number, step_name, test_name,
-     version_number, suspected_build_number) = flake_info.split('/')
+    master_name = self.request.get('master_name').strip()
+    builder_name = self.request.get('builder_name').strip()
+    build_number = self.request.get('build_number').strip()
+    step_name = self.request.get('step_name').strip()
+    test_name = self.request.get('test_name').strip()
+    version_number = self.request.get('version_number').strip()

[stgao, 2016/12/07 20:12:50]

Would it be easier if we use the key.urlsafe() just like Chan's CL yesterday?

[chanli, 2016/12/07 20:56:12]

Agreed. 

[lijeffrey, 2016/12/07 22:02:03]

That's much cleaner! Done.

+    suspected_build_number = self.request.get('suspected_build_number').strip()
     triage_result = self.request.get('triage_result')
 
     if not (master_name and builder_name and build_number and step_name and
             test_name and version_number and suspected_build_number and
             str(triage_result)):
       # All fields needed for getting master_flake_analysis must be provided in
       # order to update triage results.
       return {'data': {'success': False}}
 
     # As the permission level is CORP_USER, we could assume the current user
     # already logged in.
     user_name = users.get_current_user().email().split('@')[0]
 
     success = _UpdateSuspectedFlakeAnalysis(
         master_name, builder_name, build_number, step_name, test_name,
         int(version_number), suspected_build_number, int(triage_result),
         user_name)
 
     return {'data': {'success': success}}
 
   def HandlePost(self):  # pragma: no cover
     return self.HandleGet()