Deprecate UnthrottledThreadTimer.

Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
Committed: https://crrev.com/942fe9a2a22a011760ab7a278f90cadd36872b84
Cr-Commit-Position: refs/heads/master@{#440099}

[altimin, 2016-12-06 19:04:06]

Description was changed from

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
==========

to

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
==========

[altimin, 2016-12-06 19:04:11]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-06 19:05:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2016-12-06 19:06:01]

PTAL

[altimin, 2016-12-06 19:07:02]

Description was changed from

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
==========

to

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
==========

[commit-bot: I haz the power, 2016-12-06 21:20:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 21:20:11]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2016-12-06 23:45:27]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org

[haraken, 2016-12-06 23:45:28]

https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/Timer.h (right):

https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/Timer.h:183: // DEPRECATED: Use
TaskRunnerHelper::get with TaskType::Unthrottled.

dcheng@ introduced UnthrottledThreadTimer. What's your plan about it?

https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/Timer.h:185: class UnthrottledThreadTimer :
public TaskRunnerTimer<TimerFiredClass> {

dcheng@ introduced UnthrottledThreadTimer. What's your plan about this?

[dcheng, 2016-12-07 03:15:49]

https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/Timer.h (right):

https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/Timer.h:185: class UnthrottledThreadTimer :
public TaskRunnerTimer<TimerFiredClass> {
On 2016/12/06 23:45:28, haraken wrote:
> 
> dcheng@ introduced UnthrottledThreadTimer. What's your plan about this?

It wasn't clear to me if we'd have thing that needed to be unthrottled thread
timers. I was going to revisit this once I have landed more CLs for the timer
changes.

I don't have a strong feeling about marking/not marking this as deprecated; it
certainly seems reasonable to encourage the use of per-frame timers where
possible, and I expect the fate of UnthrottledThreadTimer will become clearer
near the end of December.

[haraken, 2016-12-07 03:57:37]

On 2016/12/07 03:15:49, dcheng wrote:
>
https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/Timer.h (right):
> 
>
https://codereview.chromium.org/2554113002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/Timer.h:185: class UnthrottledThreadTimer :
> public TaskRunnerTimer<TimerFiredClass> {
> On 2016/12/06 23:45:28, haraken wrote:
> > 
> > dcheng@ introduced UnthrottledThreadTimer. What's your plan about this?
> 
> It wasn't clear to me if we'd have thing that needed to be unthrottled thread
> timers. I was going to revisit this once I have landed more CLs for the timer
> changes.
> 
> I don't have a strong feeling about marking/not marking this as deprecated; it
> certainly seems reasonable to encourage the use of per-frame timers where
> possible, and I expect the fate of UnthrottledThreadTimer will become clearer
> near the end of December.

I'll defer this review to you :)

[mlamouri (slow - plz ping), 2016-12-07 14:47:02]

Assuming the behaviour stays the same, HTMLMediaElement lgtm

[altimin, 2016-12-07 14:52:30]

On 2016/12/07 14:47:02, mlamouri wrote:
> Assuming the behaviour stays the same, HTMLMediaElement lgtm

I just found out that there is a problem when HTMLMediaElement is moved between
different documents.
The plan here is to support moving timers between different TaskRunners (in a
different patch) and update
HTMLMediaElement::didMoveToNewDocument. 

Mounir, how does it sound to you?

[dcheng, 2016-12-07 18:25:38]

On 2016/12/07 14:52:30, altimin wrote:
> On 2016/12/07 14:47:02, mlamouri wrote:
> > Assuming the behaviour stays the same, HTMLMediaElement lgtm
> 
> I just found out that there is a problem when HTMLMediaElement is moved
between
> different documents.
> The plan here is to support moving timers between different TaskRunners (in a
> different patch) and update
> HTMLMediaElement::didMoveToNewDocument. 
> 
> Mounir, how does it sound to you?

OK, so I should defer reviewing this until we can move timers between task
runners?

[altimin, 2016-12-07 18:52:26]

On 2016/12/07 18:25:38, dcheng wrote:
> On 2016/12/07 14:52:30, altimin wrote:
> > On 2016/12/07 14:47:02, mlamouri wrote:
> > > Assuming the behaviour stays the same, HTMLMediaElement lgtm
> > 
> > I just found out that there is a problem when HTMLMediaElement is moved
> between
> > different documents.
> > The plan here is to support moving timers between different TaskRunners (in
a
> > different patch) and update
> > HTMLMediaElement::didMoveToNewDocument. 
> > 
> > Mounir, how does it sound to you?
> 
> OK, so I should defer reviewing this until we can move timers between task
> runners?

I think that you can take a look at it now, the most important question is if
you agree with deprecation of UnthrottledThreadTimer. The timer movement thing
is a minor technical thing (patch for it is in
https://codereview.chromium.org/2556053004/), but you can review it later, if
you think that it's the best way.

[dcheng, 2016-12-08 08:15:40]

LGTM

Just so I understand correctly, even without moving the timers, this will still
work correctly: it just means a media element might conceptually be in the wrong
task queue, right?

[haraken, 2016-12-08 08:22:04]

LGTM

[mlamouri (slow - plz ping), 2016-12-08 14:11:19]

On 2016/12/07 at 14:52:30, altimin wrote:
> On 2016/12/07 14:47:02, mlamouri wrote:
> > Assuming the behaviour stays the same, HTMLMediaElement lgtm
> 
> I just found out that there is a problem when HTMLMediaElement is moved
between different documents.
> The plan here is to support moving timers between different TaskRunners (in a
different patch) and update
> HTMLMediaElement::didMoveToNewDocument. 
> 
> Mounir, how does it sound to you?

sgtm - can you send me the CL that does the follow-up?

[altimin, 2016-12-09 14:05:34]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 14:05:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 16:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 16:05:14]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[altimin, 2016-12-15 13:55:56]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 13:56:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 13:58:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 13:58:01]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[altimin, 2016-12-15 14:05:42]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:05:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:07:42]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[altimin, 2016-12-15 14:25:46]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 14:26:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 14:27:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 14:27:34]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[altimin, 2016-12-16 15:04:04]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:04:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:05:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 15:05:41]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[altimin, 2016-12-16 15:24:27]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:24:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 15:26:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 15:26:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[altimin, 2016-12-16 15:38:06]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 15:38:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 17:33:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 17:33:27]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[altimin, 2016-12-20 15:16:21]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 15:16:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 16:51:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 16:51:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[altimin, 2016-12-21 11:58:05]

The CQ bit was checked by altimin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 11:58:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 13:31:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 13:31:50]

Dry run: This issue passed the CQ dry run.

[altimin, 2016-12-21 14:51:06]

The CQ bit was checked by altimin@chromium.org

[altimin, 2016-12-21 14:51:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, dcheng@chromium.org, mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/2554113002/#ps100001
(title: "Move forgotten timer too")

[commit-bot: I haz the power, 2016-12-21 14:51:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 14:55:38]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1482331866426210,
"parent_rev": "a1fabe49844819e3dcea6340ad4000c99dae8c94", "commit_rev":
"7471647089534dd5e7bc2c8ccce79d51bfb8f5bd"}

[commit-bot: I haz the power, 2016-12-21 14:56:03]

Description was changed from

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696
==========

to

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696

Review-Url: https://codereview.chromium.org/2554113002
==========

[commit-bot: I haz the power, 2016-12-21 14:56:04]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-21 14:58:24]

Description was changed from

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696

Review-Url: https://codereview.chromium.org/2554113002
==========

to

==========
Deprecate UnthrottledThreadTimer.

Per the effort of moving tasks to per-frame task queues, instead of
UnthrottledThreadTimer TaskRunnerTimer with appropriate WebTaskRunner
should be used. TaskRunnerHelper::get(TaskType::Unthrottled, ...) will
return the right WebTaskRunner.

Also this patch fixes usages of UnthrottledThreadTimer in HTMLMediaElement.

R=haraken@chromium.org,mlamouri@chromium.org

BUG=624696

Committed: https://crrev.com/942fe9a2a22a011760ab7a278f90cadd36872b84
Cr-Commit-Position: refs/heads/master@{#440099}
==========

[commit-bot: I haz the power, 2016-12-21 14:58:26]

Patchset 6 (id:??) landed as
https://crrev.com/942fe9a2a22a011760ab7a278f90cadd36872b84
Cr-Commit-Position: refs/heads/master@{#440099}