Cast: Isolate for tab capture end2end test

Cast: Isolate for tab capture end2end test

BUG=365927
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271420

[hubbe, 2014-04-24 20:10:16]

Works locally at least. :)

[Ken Russell (switch to Gerrit), 2014-04-24 23:52:45]

Thanks for putting this together.

After more thought I don't think it's needed. You can just build the
browser_tests isolate (by building the browser_tests_run target in the GPU
recipe) and then add on the --gtest-filter argument. See the passing of "args"
to _maybe_run_isolate in recipe_modules/gpu/api.py.

The real key will be for you to run the GPU recipe locally and make sure that it
picks up and invokes the browser_tests isolate appropriately. You can actually
build and upload the isolate from your Chromium checkout and then just run the
download_and_test recipe, which will be much faster than running build_and_test
or build_and_upload/download_and_test.

[hubbe, 2014-05-14 17:07:46]

PTAL

[hubbe, 2014-05-14 17:11:17]

On 2014/05/14 17:07:46, hubbe wrote:
> PTAL

Oops, hold on. Failed to upload.

[hubbe, 2014-05-14 17:16:33]

PTAL, for real this time

[Ken Russell (switch to Gerrit), 2014-05-14 19:18:57]

https://codereview.chromium.org/255403007/diff/60001/chrome/tab_capture_end2e...
File chrome/tab_capture_end2end_tests.isolate (right):

https://codereview.chromium.org/255403007/diff/60001/chrome/tab_capture_end2e...
chrome/tab_capture_end2end_tests.isolate:9: ['OS=="mac" or OS=="win"', {
Should be 'OS=="linux" or OS=="mac" or OS=="win"'

[Ken Russell (switch to Gerrit), 2014-05-14 19:20:08]

Also, I linked to bug 365927 in the description.

[hubbe, 2014-05-14 21:03:36]

PTAL, actually managed to test it this time!

[Ken Russell (switch to Gerrit), 2014-05-14 21:16:16]

LGTM

[hubbe, 2014-05-14 21:17:33]

The CQ bit was checked by hubbe@chromium.org

[commit-bot: I haz the power, 2014-05-14 21:19:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/255403007/80001

[commit-bot: I haz the power, 2014-05-14 22:49:01]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/18...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)

[Ken Russell (switch to Gerrit), 2014-05-14 22:50:40]

https://codereview.chromium.org/255403007/diff/80001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

https://codereview.chromium.org/255403007/diff/80001/chrome/chrome_tests.gypi...
chrome/chrome_tests.gypi:2903: 'tab_capture_end2endtests.isolate',
The isolate is named differently!

[commit-bot: I haz the power, 2014-05-14 22:53:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-14 22:53:53]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[hubbe, 2014-05-16 00:05:16]

PTAL?
Check commit box if you think it looks good.

[Ken Russell (switch to Gerrit), 2014-05-16 00:09:30]

Thanks, looks good. CQ'ing.

[Ken Russell (switch to Gerrit), 2014-05-16 00:09:41]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-05-16 00:10:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/255403007/100001

[commit-bot: I haz the power, 2014-05-16 04:01:53]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-16 04:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-16 04:04:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[hubbe, 2014-05-16 04:06:37]

+sky for OWNERS approval

[sky, 2014-05-16 17:01:53]

+pawel

[sky, 2014-05-16 20:47:02]

LGTM

[Ken Russell (switch to Gerrit), 2014-05-16 20:47:33]

Did over-the-shoulder review with sky@. CQ'ing again.

[Ken Russell (switch to Gerrit), 2014-05-16 20:47:37]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-05-16 20:47:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/255403007/100001

[commit-bot: I haz the power, 2014-05-17 01:03:27]

The CQ bit was unchecked by commit-bot@chromium.org

[Paweł Hajdan Jr., 2014-05-19 10:23:22]

Fine with the change (did you mean maruel@ for .isolate changes?), just note a
possible issue.

https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
File chrome/tab_capture_end2end_tests.isolate (right):

https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
chrome/tab_capture_end2end_tests.isolate:17:
'--gtest_filter=TabCaptureApiPixelTest.EndToEnd*',
I don't recommend using gtest_filter in this way. Depending on what you're
trying to do, there should be a better way.

Main part of the rationale is that it becomes *significantly* harder to ensure
separate configs (like CQ and main waterfall) are in sync when gtest_filter is
present.

[hubbe, 2014-05-19 17:14:24]

On 2014/05/19 10:23:22, Paweł Hajdan Jr. wrote:
> Fine with the change (did you mean maruel@ for .isolate changes?), just note a
> possible issue.
> 
>
https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
> File chrome/tab_capture_end2end_tests.isolate (right):
> 
>
https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
> chrome/tab_capture_end2end_tests.isolate:17:
> '--gtest_filter=TabCaptureApiPixelTest.EndToEnd*',
> I don't recommend using gtest_filter in this way. Depending on what you're
> trying to do, there should be a better way.
> 
> Main part of the rationale is that it becomes *significantly* harder to ensure
> separate configs (like CQ and main waterfall) are in sync when gtest_filter is
> present.

How do you run the isolate locally without having all the arguments it needs in
it?

[Ken Russell (switch to Gerrit), 2014-05-19 17:47:21]

https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
File chrome/tab_capture_end2end_tests.isolate (right):

https://codereview.chromium.org/255403007/diff/100001/chrome/tab_capture_end2...
chrome/tab_capture_end2end_tests.isolate:17:
'--gtest_filter=TabCaptureApiPixelTest.EndToEnd*',
On 2014/05/19 10:23:23, Paweł Hajdan Jr. wrote:
> I don't recommend using gtest_filter in this way. Depending on what you're
> trying to do, there should be a better way.
> 
> Main part of the rationale is that it becomes *significantly* harder to ensure
> separate configs (like CQ and main waterfall) are in sync when gtest_filter is
> present.

The intent is to run a small subset of the browser_tests. Can you suggest
another way?

Note I specifically do not want to put the gtest_filter in the GPU recipe. We've
run into multiple problems trying to make changes to tests' configurations when
some of the configuration is in the recipe and the rest is in the Chromium
workspace. The configuration of these tests should be entirely in the Chromium
workspace and thus in the isolate.

[Ken Russell (switch to Gerrit), 2014-05-19 17:48:40]

Going to try CQ'ing this again. We can decide how to configure the isolate
later.

[Ken Russell (switch to Gerrit), 2014-05-19 17:48:47]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2014-05-19 17:49:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hubbe@chromium.org/255403007/100001

[commit-bot: I haz the power, 2014-05-19 18:00:19]

Change committed as 271420